Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kslabel good in Phy #38

Closed
kevinbolding opened this issue Mar 23, 2019 · 4 comments · Fixed by #595
Closed

kslabel good in Phy #38

kevinbolding opened this issue Mar 23, 2019 · 4 comments · Fixed by #595

Comments

@kevinbolding
Copy link

The quoted documentation below makes it appear that when KS2 is done and results are saved using the Kilosort GUI, the 'good' units should be labeled as such when the results are opened in Phy. I installed yesterday (March 22, 2019) in Windows 10, according to the Phy install instructions and I am not seeing any labeling. I have found the cluster_KSlabel.tsv and can interpret this in MATLAB, but am not certain how to inform Phy about it's existence. Is this not fully implemented yet or am I missing something in my setup or data management?

Kilosort2 automatically sets the "good" units in Phy based on a <20% estimated contamination rate with spikes from other neurons (computed from the refractory period violations relative to expected).

@marius10p
Copy link
Contributor

Did you install the development version of Phy? There should be some stats in the cluster list, including whether KS2 thought it was "good"/

@kevinbolding
Copy link
Author

I believe that I have installed the development version, I am attaching evidence thereof.
phydevelopinstall

I'm not certain what else would be diagnostic, so I've attached a view of template-gui upon opening and a view of the folder contents for the recording.
templateguiopeningview
phytestfoldercontents

@marius10p
Copy link
Contributor

marius10p commented Mar 24, 2019

The full command is in the main phy readme at https://github.com/kwikteam/phy.

activate phy
pip install git+https://github.com/kwikteam/phy git+https://github.com/kwikteam/phy-contrib --upgrade

I think what you are missing is the clone of the latest phy repository. I don't think you need to run "python setup.py develop", maybe yours are some older instructions?

@kevinbolding
Copy link
Author

Solved (by running this exact command)! Thank you!

carsen-stringer pushed a commit that referenced this issue Feb 29, 2024
Add an option to select the data dtype in the gui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants