Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nt0 is hard-coded #401

Closed
WeissShahaf opened this issue May 18, 2021 · 6 comments · Fixed by #595
Closed

nt0 is hard-coded #401

WeissShahaf opened this issue May 18, 2021 · 6 comments · Fixed by #595

Comments

@WeissShahaf
Copy link

Hello,
I've been experimenting with increasing the sample window nt0 to =81 in kilosort3 (but this issue probably exists in kilosort2+), as my spikes are very long.
unfortunately, I've had to recursively change many lines in the code to do that, as the 61 value is assumed at various points in the code.

not sure I got it all.

perhaps you can fix this more easily than me.

thanks

@JonathanAMichaels
Copy link

Were you able to get the code working for nt0 > 61 @WeissShahaf? I changed all the hardcoded entries, but I'm getting CUDA errors. So, there may be aspects of the CUDA code that do not allow this.

@WeissShahaf
Copy link
Author

81 worked for me. but i did have to change alot of code

@JonathanAMichaels
Copy link

I changed all locations where a "61" was hard-coded to ops.nt0, but these were only a few cases. Do you remember what else you had to change?

@WeissShahaf
Copy link
Author

unfortunately no. sorry.
i quit using kilosort since, maybe will return one day

@JonathanAMichaels
Copy link

@WeissShahaf do you still have that code lying around anywhere that you could send for me to look at? It seems that nt0 > 64 breaks mexGetSpikes2.cu

@WeissShahaf
Copy link
Author

WeissShahaf commented Jan 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants