Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in preprocessDataSub? #53

Closed
HiroMiyawaki opened this issue Apr 9, 2019 · 2 comments · Fixed by #595
Closed

A bug in preprocessDataSub? #53

HiroMiyawaki opened this issue Apr 9, 2019 · 2 comments · Fixed by #595

Comments

@HiroMiyawaki
Copy link

In the high pass filtering loop in preprocessDataSub.m,
reading frame progresses by [NT-ops.ntbuff] sample points,
but [NT] sample points are written to temp_wh.dat,
so the filtered signal becomes longer than the original dat.

Is it intentional?
I thought it's a bug, but somehow final results seem fine.

@HiroMiyawaki
Copy link
Author

I think it is intentional.
temp_wh.dat includes buffers used later in learnAndSolve8b.m. Right?

@marius10p
Copy link
Contributor

Correct, it is intentional to reduce artifacts at transitions between batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants