Duplicating KSLabel for clusters into cluster_group #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicates cluster_KSLabel.tsv into cluster_group.tsv, which should be respected by Phy for things like filtering in the cluster view (e.g. `group == 'good'`, highlighting in green, etc.).
|
I merged this in, but it doesn't look like Phy2 is highlighting units in green by default. |
Merged
cnuahs
pushed a commit
to cnuahs/Kilosort
that referenced
this pull request
Mar 9, 2024
Duplicating KSLabel for clusters into cluster_group Former-commit-id: b256cae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates cluster_KSLabel.tsv into cluster_group.tsv, which should be
respected by Phy for things like filtering in the cluster view (e.g.
group == 'good', highlighting in green, etc.).@marius10p ?