KS3 fixes: do-over pull request #324
Closed
+316
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- impose limit to NchanNear for recordings with <100 channels
- GUI: parameterize font size
- GUI: don't crash if default WindowStyle == 'docked'
- Don't reuse figure for datashift plot
- Mmuch faster loading of data for computing whitening matrix
- - Activate by setting ops.useMemMapping = true
- - same method would be great when loading & saving filtered dat,
but cannot parse method of including overlapping buffers w/in
filtered data output (can buffer sampling not be done on GPU??)
** svdecon.m was inconsistently performing gpuArray gather,
leading to error attempting to convert "to single from gpuArray"
(Matlab 2019a, Ubuntu 18.04). Added a gather where looked least
intrusive, but just a guess...
…ng data loading in get_whitening_matrix_faster.m
- reverted original copy of get_whitening_matrix.m - replace with `get_whitening_matrix_faster.m` on linux to speed up loading with memmapping & parfor
|
Thanks. I see that you pushed your commits over the previous commits, undoing some and changing some. Sorry, but can you please start with a clean repo and add the minimal changes you want to make to that? Currently I cannot verify if the things you added and then taken back have reverted those functions to their original. Also, we don't need a zero-crossing value (that's what ops.nt0min is), and I think sig doesn't need to be parametrized either: it's a property of the waveforms in tissue, i.e. the minimum spatial distance over which we expect waveforms to change. |
|
Submitted another PR with these changes merged with upstream changes that you'd already made into other commits.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core
Cosmetic