Skip to content

Commit

Permalink
numpy<=1.16.6 in environment (#110) and issue with .cellpose folder n…
Browse files Browse the repository at this point in the history
…ot being created (#112)
  • Loading branch information
carsen-stringer committed Aug 30, 2020
1 parent cc93a94 commit 13db32e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions cellpose/gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ def run(image=None):
app = QtGui.QApplication(sys.argv)
icon_path = pathlib.Path.home().joinpath('.cellpose', 'logo.png')
if not icon_path.is_file():
cp_dir = pathlib.Path.home().joinpath('.cellpose')
cp_dir.mkdir(exist_ok=True)
print('downloading logo')
utils.download_url_to_file('http://www.cellpose.org/static/images/cellpose_transparent.png', icon_path, progress=True)
icon_path = str(icon_path.resolve())
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: cellpose
dependencies:
- python>3.4,<3.8
- pip
- numpy
- numpy<=1.16.6
- numba>=0.43.1
- pyqt
- scipy
Expand Down

1 comment on commit 13db32e

@chrisroat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an explanation for pinning numpy in the environment? Should it be pinned in setup.py as well?

I ask because I install directly from pypi or github branches, which both use setup.py.

Please sign in to comment.