Remove global logging setup #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have much to add, except moral support. I hope this PR can be merged to master soon as I would greatly appreciate implementing this change in my workflow (MERFISH analysis). |
|
this is great thanks, I am happy with the new implementation, I will call the logger in the jupyter-notebook example as well to activate it for the user. |
|
is it possible to release it on pip? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #295, libraries generally avoid setting up logging. That should left to the applications calling the code.
The default logging writes to a file in the home directory, which leads to trouble if multiple runs of cellpose are executing which access the same home directory, or the program does not have write access to that directory.
Closes #295