Detection module refactor: stats.py #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeping behavior, move overlap assignment to main loop.
…ls, for simpler logical indexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request splits out the algorithmic and data aggregation steps in stats.py, making the code more testable while still user-friendly. The major feature addition here is the ROI dataclass, a frozen class which does data validation on ypix, xpix, and lam and provides handles to the main roi calculation operations, using cached properties to reduce recomputation time on the most heavy and repeated operations.
The compilation of the stats array of dicts is moved out of stats.py and into detect.select_rois() to increase transparency and make optimization simpler. Further refactoring is needed for seperating out the behaviors of sparsery(), sourcery(), and select_rois().
Best wishes,
Nick