fix(permission): check and request permission should ignore url port #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same cookie is shared by different ports of the same domain name. If a port is added when request permission, the urls of different ports of the same domain name cannot access the current cookie. For example, localhost:8080 requires the cookie of localhost
njzydark
force-pushed
the
fix-perimission
branch
from
99a8986
to
b0df166
Compare
adanatravesti
approved these changes
Dec 27, 2023
|
Thank you for the contribution and sorry for the late approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same cookie is shared by different ports of the same domain name. If a port is added when request permission, the urls of different ports of the same domain name cannot access the current cookie. For example, localhost:8080 requires the cookie of localhost
close #66
close #142
close #135