Many new features, some fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: For Rooms that are in the config file, we want them to be persistent, for those we will add a flag for mark them as fixed, and add a check before removing the room.
…edsongs script takes 1 parameter(-r or -u)
skillset(generalised)
see if all players use hashing(does nothing atm)
…. Add toasties, extra toasty xp and storing them in song_stats
sending if all users in room support it
… Store song file hash, chartkey and rate for each play
showing bests scores on song select optional(default to false)
display on message(room option), change display percentage to %
check. Calc migs points on status_update. Change player rating system to skillet-less.
validation. Calculate ingame scoreboard grade server-side. Add message when you play a ranked song
…holds from dp percentage calc. Send migs % with the options string as SMO does.
…d. New tables charts and simfiles. Add wife scoring function in status_update(not used atm).
Moved point/grade calc functions to song_stat as static mehtods of SongStat. Improve load_ranked_charts script. Add jumps/hands to xp calc
Remove room name from room messages. Decrease default xp gain. Link ranked charts to a song(metadata). Send message when user rating updates. Make /profile show other people's profiles.
changes(game starts/ends) and send users that come in the last selected song instead of the last played song.
table packsimfiles which will be used to link simfiles to packs
remove calc_percentage, dont delete room if static
|
Hi ! Thx far all the work you've done! I will be glad to work with you! Actually I'm trying to improve the test coverage of the server in order to work easily on it. I also have a lot of things to do in the roadmap I have in my mind ^^ I will try to merge the work you've done little by little. Can you do little PR in order to merge it ? Or can you redo this PR in another branch that i will merge to work on it ? |
Moutix
added a commit
that referenced
this pull request
Feb 5, 2017
|
Hey! i just finished merging and fixing conflicts with your current repo in here: https://github.com/Nickito12/stepmania-server/tree/experimental |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This is an amazing server you're working on!
The owner of stepmaniaonline.net said he's interested in migrating to this server eventually(They're currently using https://github.com/concubidated/OpenSMO). I've been working on trying to improve this server a bit for him to use. I'd like to talk to you if you're interested since i'm not very good with python and I'd love working with someone who knows what he's doing(i couldn't find a way to contact you, hence this pull request). There's a test server hosted on stepmaniaonline.net:8888 right now with this fork. If you're interested email me(abramlujan@gmail.com)
These are the things I've been working on:
--Friend/ignore system(With optional notifications when they go online/offline)
--PM(messaging)
--Fix lobby userlist updates
--Fix song ended checking for some cases
--Added support for clients that send chartkeys/songfilehashes/notesizes and FLU(Friendlist Update) packets(I've also been working on the client to add these things). Keeps compatibility with "old" clients
--Some grammar fixes
--Total best and Personal best message display on song end
--All the information on song end in 1 message(So it doesnt take as much space, each message has a line break which wastes some space in my opinion)
--Made "display best scores on song select" a room option, default is off(It can take a lot of space)
--Added judgement being calculated server-side(So if a user is playing on a judge different from 4 we still get the J4 score), points, percentage and grade too.
--Made jumps/hands/quads give more xp
--Added migs percentage/points calculating and storing(This makes it possible to compare scores that are AAA or above)
--Added a room option to display the song_stat's points in the messages
--Added a /profile command that displays XP, rating and rank of a given user
--Added a check to see if all players have the song before starting(Also added a room option to make it possible to start a song even if not everyone in the room has it, though it defaults to false)
--Changed default grade to D(So empty scores arent AAAA)
--Added a wife scoring function, even though it is not used currently(Since wife scoring changes based on a few ms of difference i dont think it's reliable online, because there are delays)
--Store simfiles/charts using chartkeys and song filehashes. The model is like this:
A song is metadata(artist/title/subtitle)
Each song can have many simfiles(Each file for a song) defined by a filehash
Each simfile can have many charts(difficulties) defined by a chartkey
--Added a ranked charts system and player rating/ranking using said ranked charts