Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lobby userlist and roomlist updating #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nico-abram
Copy link

Fix lobby room and userlist updates

@Moutix
Copy link
Owner

Moutix commented Jun 12, 2017

If I didn't send the lobby user list, it's because it's limited to 255 users do we really need to send it?

@nico-abram
Copy link
Author

I dont think sending the lobby userlist properly is a bad idea. That said i can see it not being a priority.
What i do think is a priority is the room list(without it users cant properly recognize/join rooms. Even the state is important in my opinion(a player in a hurry might be looking for a room not in a game).
And, if i remember correctly, the lobby userlist and room list are sent in the same packet(therefore not updating the userlist but updating the room list wouldnt make much difference i think)

@coveralls
Copy link

coveralls commented Jun 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 84.68% when pulling 5a24975 on Nickito12:LobbyUpdates into d3353ac on ningirsu:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants