Adds typecasting to parameters

moveline · Oct 11, 2012 · 0184238 · 0184238
1 parent c992dc9
commit 0184238
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/pagination.js b/lib/pagination.js
@@ -1,8 +1,8 @@
 var mongoose = require('mongoose');
 
 mongoose.Query.prototype.paginate = function paginate (page, limit, cb) {
-  page = page || 1;
-  limit = limit || 10;
+  page = parseInt(page, 10) || 1;
+  limit = parseInt(limit, 10) || 10;
 
   var query = this;
   var model = this.model;

diff --git a/test/paginate.coffee b/test/paginate.coffee
@@ -41,3 +41,9 @@ describe 'Mongoose Pagination', ->
       query.options.should.include.keys 'skip', 'limit'
       query.options.skip.should.be.eq 30
       query.options.limit.should.be.eq 15
+
+    it 'should skip 30 when page is "3" and limit is "15"', ->
+      query.paginate "3", "15"
+      query.options.should.include.keys 'skip', 'limit'
+      query.options.skip.should.be.eq 30
+      query.options.limit.should.be.eq 15