Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change VersionRange comparison so 2.0-SNAPSHOT does not satisfy 2.0 #113

Closed
keturn opened this issue May 1, 2021 · 1 comment · Fixed by #115
Closed

change VersionRange comparison so 2.0-SNAPSHOT does not satisfy 2.0 #113

keturn opened this issue May 1, 2021 · 1 comment · Fixed by #115
Labels
Topic: Module Requests, Issues and Changes related to gestalt modules
Projects
gestalt v7 migration (module & asset)
Milestone
v7.1.0

Comments

@keturn
Copy link
Member

keturn commented May 1, 2021

We've decided to change version comparison to be more consistent with Semantic Versioning.

Currently a dependency declared as 2.0.0 may be satisfied by a module implementing 2.0.0-SNAPSHOT. This should not be true under semantic versioning.

Requires a change to the VersionRange class and tests, as well as documentation. (Check both Terasology and gestalt wikis.)
@keturn keturn added Topic: Module Requests, Issues and Changes related to gestalt modules v7 labels May 1, 2021
@keturn keturn added this to the v7.1.0 milestone May 1, 2021
@keturn keturn added this to To do in gestalt v7 migration (module & asset) via automation May 1, 2021
@keturn keturn mentioned this issue May 1, 2021
Closed
This was referenced May 4, 2021
Merged
Merged
@jdrueckert
Copy link
Member

Closed by #115

gestalt v7 migration (module & asset) automation moved this from To do to Done May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic: Module Requests, Issues and Changes related to gestalt modules
Projects
gestalt v7 migration (module & asset)
  
Done
Milestone
v7.1.0
Development

Successfully merging a pull request may close this issue.

feat!: make version comparison semver compliant MovingBlocks/gestalt
2 participants
@keturn @jdrueckert