support undo/redo with truncate #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail because termion is reporting the terminal witdh to be 0. Liner does not like this. Not sure how to fix this, the same thing happens if I run in lldb on my mac. Note: tests pass when I run |
|
This has some bugs in it. It only works if you delete the entire line. Working on a fix for partial deletes. |
iamcodemaker
force-pushed
the
truncateundo
branch
from
5c48103
to
4d879f5
Compare
|
Fixed. |
|
Just pushed a new rev that fixes the tests. |
|
I'm not sure if there needs to be a separate |
|
Could do this with |
When testing on travis, the terminal width is returned as 0 which leads to a divide-by-zero error. Hardcoding the size when testing avoids this issue.
iamcodemaker
force-pushed
the
truncateundo
branch
from
087823a
to
b357c70
Compare
|
Ok, I reworked the patch to use the |
Prior to this patch, typing some text, moving to the start of the line, then deleting until the end of the line and attempting to undo will cause a panic. This is because the truncate() operation did not update the undo list. This has been corrected.
iamcodemaker
force-pushed
the
truncateundo
branch
from
b357c70
to
82184e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, typing some text, moving to the start of the line,
then deleting until the end of the line and attempting to undo will
cause a panic. This is because the truncate() operation did not update
the undo list. This has been corrected.