Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage : Moya requires at least osx 10.11 #1441

Closed
lucas34 opened this issue Nov 3, 2017 · 3 comments
Closed

Carthage : Moya requires at least osx 10.11 #1441

lucas34 opened this issue Nov 3, 2017 · 3 comments

Comments

@lucas34
Copy link
Member

lucas34 commented Nov 3, 2017

Hi,

As defined in podspec, the minimal deployment target is 10.10. But when using carthage the lib requires 10.11.

@sunshinejr
Copy link
Member

Hey @lucas34, thanks for reporting the issue. You are right, our CocoaPods config requires 10.10, but from the quick look at our xcodeproj, it seems like we have deployment target for macOS on 10.11. Not sure why, but it seems like a bug. Would you be up for changing this one? I think that it would require changes only in the xcodeproj, wherever we have MACOSX_DEPLOYMENT_TARGET = 10.11.

@BasThomas
Copy link
Contributor

Do we need to target 10.11 for a reason though, or can we change the podspec to 10.10?

@sunshinejr
Copy link
Member

sunshinejr commented Nov 3, 2017

@BasThomas our podspec already uses 10.10, thus I believe that this is a bug that our Moya.xcodeproj uses 10.11 as a deployment target and it should be safe to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants