Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Info.plist to remove SPM warning #2208

Merged
merged 3 commits into from Nov 15, 2021
Merged

Conversation

TTOzzi
Copy link
Member

@TTOzzi TTOzzi commented Sep 19, 2021

Xcode throws a package loading warning while building Moya.

found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target

Exclude Info.plist to remove warning :D

@MoyaBot
Copy link

MoyaBot commented Sep 19, 2021

Warnings
⚠️ ld: dylib (/Applications/Xcode-12.5.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib/libXCTestSwiftSupport.dylib) was built for newer macOS version (10.15) than being linked (10.12)
⚠️ ld: dylib (/Applications/Xcode-12.5.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/XCTest.framework/XCTest) was built for newer macOS version (10.15) than being linked (10.12)
⚠️

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

⚠️

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

⚠️

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

⚠️ The Package.swift was updated, but there were no changes in Moya.podspec, Cartfile, Cartfile.resolved, Package.resolved. Did you forget to update them?
Messages
📖 macOS: Executed 321 tests, with 0 failures (0 unexpected) in 17.645 (17.974) seconds
📖 tvOS: Executed 321 tests, with 0 failures (0 unexpected) in 14.288 (14.688) seconds
📖 iOS: Executed 321 tests, with 0 failures (0 unexpected) in 14.863 (15.333) seconds

Generated by 🚫 Danger Swift against c9782be

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #2208 (c9782be) into master (464c29d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files          30       30           
  Lines         991      991           
=======================================
  Hits          884      884           
  Misses        107      107           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464c29d...c9782be. Read the comment docs.

@denizdogan
Copy link

Anything preventing this from being merged? Seems straightforward to me.

@hewigovens
Copy link

@sunshinejr @ashfurrow could you please review and merge this? Currently this is the only warning left in our project, we just fully migrated to SPM, Thanks!

Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not typically an SPM user but this change makes sense to me. There's also overwhelming 👍 support so I'm comfortable merging. Thanks for the PR, and for your patience 😅

@ashfurrow ashfurrow merged commit 6959c44 into Moya:master Nov 15, 2021
@peril-moya
Copy link

peril-moya bot commented Nov 15, 2021

@TTOzzi Thanks a lot for contributing to Moya! We've invited you to join
the Moya GitHub organization – no pressure to accept! If you'd like more
information on what that means, check out our contributor guidelines and
feel free to reach out to @Moya/core-team with any questions.

Generated by 🚫 dangerJS

@Adrift001 Adrift001 mentioned this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants