New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Info.plist to remove SPM warning #2208
Conversation
Generated by 🚫 Danger Swift against c9782be |
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
=======================================
Coverage 89.20% 89.20%
=======================================
Files 30 30
Lines 991 991
=======================================
Hits 884 884
Misses 107 107 Continue to review full report at Codecov.
|
Anything preventing this from being merged? Seems straightforward to me. |
@sunshinejr @ashfurrow could you please review and merge this? Currently this is the only warning left in our project, we just fully migrated to SPM, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not typically an SPM user but this change makes sense to me. There's also overwhelming 👍 support so I'm comfortable merging. Thanks for the PR, and for your patience 😅
@TTOzzi Thanks a lot for contributing to Moya! We've invited you to join Generated by 🚫 dangerJS |
Xcode throws a package loading warning while building Moya.
found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
Exclude Info.plist to remove warning :D