[gardening] remove unecessary headers and plists causing SPM warnings #2203
Conversation
| .package(url: "https://github.com/AliSoftware/OHHTTPStubs.git", .upToNextMajor(from: "9.0.0")) // dev | ||
| .package(url: "https://github.com/Alamofire/Alamofire.git", from: "5.4.3"), | ||
| .package(url: "https://github.com/ReactiveCocoa/ReactiveSwift.git", from: "6.6.1"), | ||
| .package(url: "https://github.com/ReactiveX/RxSwift.git", from: "6.2.0"), |
There was a problem hiding this comment.
I think it's better to specify the same major version as podspec than to use the fixed version.
Is there a reason why you chose a fixed version?
There was a problem hiding this comment.
the from: "semvar" is an alias for up to the next major version. so selecting Alamofire.git", from: "5.4.3" allows any version from 5.x.x
we should definitely match what the Podspec & Cartfile have, I wish there was one place we could define all of those minimum versions to stay consistent.
are the PodSpec/Cartfile significantly different?
There was a problem hiding this comment.
Is from: "5.4.3" correct to include all 5.x.x? I didn't know that. 😅
It seems confusing to me
because the document saying that it starting with the minimum version going up to the next major version.
In the podspec file it is written as ~> 5.0
how about 5.0.0 in the Package.swift file? (from: "5.0.0" or .upToNextMajor(from: "5.0.0"))
There was a problem hiding this comment.
ahh you're right, its technically 5.4.3 until 6.0.0, not including 6.0.0.
so 5.4.2 or below aren't acceptable
yeah, it is a little confusing, they're updating the SPM syntax very often
There was a problem hiding this comment.
Then, I think it would be good to change like podspec. (Alamofire, RxSwift etc..)
What do you think about it?
e.g) Alamofire
- podspec : ~> 5.0
- SPM:
from: "5.0.0"or .upToNextMajor(from: "5.0.0")
:( |
|
let me see if i can fix that build error |
@BasThomas i was seeing a warning after i switched from my
fixes-cibranch to your fixeddevelopmenti think its safe to delete these, since they aren't needed (at least for SPM) to generate a library. not very confident about this breaking Carthage/Cocoapods though, so lets merge this after CI can validate that?