Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URLEncoding.httpBody as bodyEncoding in Task #1557

Merged
merged 4 commits into from Jan 26, 2018

Conversation

sunshinejr
Copy link
Member

Fixes #1516.

@MoyaBot
Copy link

MoyaBot commented Jan 26, 2018

1 Warning
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1557 into master will increase coverage by 5.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage   82.92%   88.41%   +5.48%     
==========================================
  Files           5        5              
  Lines         164      164              
==========================================
+ Hits          136      145       +9     
+ Misses         28       19       -9
Impacted Files Coverage Δ
Sources/RxMoya/Observable+Response.swift 70.58% <0%> (+8.82%) ⬆️
Sources/ReactiveMoya/SignalProducer+Response.swift 90.9% <0%> (+9.09%) ⬆️
Sources/RxMoya/Single+Response.swift 100% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba9182...738b9ec. Read the comment docs.

Copy link
Member

@SD10 SD10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛵️

@SD10 SD10 merged commit 1902962 into master Jan 26, 2018
@sunshinejr sunshinejr deleted the fix/fix_urlencoding_in_composite_parameters branch January 26, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants