Rewording post to fit code. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was messed up? I might be missing something about the spec.
Unsure how you want to handle white space with your text wrapping but I took a stab.
slightlyoffbeat
requested changes
Sep 27, 2017
src/pages/02-first-grid.js
Outdated
| @@ -17,9 +17,9 @@ const Tutorial = () => ( | |||
|
|
|||
| <h4>Define rows and columns</h4> | |||
| <p> | |||
| There are several ways to define rows and columns. For our first grid, we will use properties | |||
| There are several ways to define rows and columns. For our first grid, we will use properties | |||
There was a problem hiding this comment.
only minor request. Can you represent the space as {' '} ?
|
Updated! Thanks for the feedback. |
slightlyoffbeat
approved these changes
Sep 27, 2017
|
Merged. Thanks! |
This was referenced Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was messed up? I might be missing something about the spec.
Here it says "To create three fixed-height rows" but we are actually creating two.
https://github.com/MozillaDevelopers/playground/blob/master/src/pages/02-first-grid.js#L22
It seems that if you have:
grid-template-columns: 150px 150px 70px;then it would only have three columns. To meet the text in the post of 'fourth' it would need to have an additional150px, or say 'third'.https://github.com/MozillaDevelopers/playground/blob/master/src/pages/02-first-grid.js#L33
https://github.com/MozillaDevelopers/playground/blob/master/src/pages/02-first-grid.js#L37
There was a missing space due to indenting for character limits on each line I'm assuming. Added one in.
Thanks for creating this site! It's very helpful.
If there is an issue I am happy to make the language consistent across this page in the direction the maintainer wants to go in so this can get merged in. :)