Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to say whether to crop or pad #8

Open
Pomax opened this issue May 6, 2021 · 0 comments
Open

Add flag to say whether to crop or pad #8

Pomax opened this issue May 6, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Pomax
Copy link
Contributor

Pomax commented May 6, 2021

image comparison only really works when the images are the same size, and there are two ways to effect that: cropping the larger image to the smaller image's size, or padding the smaller image to the larger image's size.

In both cases, we probably want to use something that can evaluate alginment really quickly so that instead of cropping blindly (e.g. padding or chopping off the right and/or bottom), we can "center" the smaller image wrt the larger image, and then pad/crop in a way that makes sure that diffing flags as few "moved" diffs as possible.

@Pomax Pomax added post-MVP post-MVP enhancement New feature or request and removed post-MVP post-MVP labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant