Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

disabled ways-to-give route #1771

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Dec 14, 2023

Description

Closes #1770

Per request of the Donate Team, we are disabling the existing WaysToGive route from the donate stack, and implementing a redirect in its place so when users visit donate.mozilla.org/en-US/ways-to-give, they get redirected to foundation.mozilla.org/en/donate/ways-to-give instead!

Steps to test

  1. Visit https://donate-wagta-1770-hide--bjnuwq.herokuapp.com/en-US/ways-to-give/
  2. Note that you now receive a 404 page instead of the "Ways-to-give" page.
  3. If the 404 Page is appearing, testing is complete! The redirect has already been implemented on production.
  4. If you would like to test the redirect, visit https://donate.mozilla.org/ways-to-give/. Note that it redirects you to https://foundation.mozilla.org/en/donate/ways-to-give/

@danielfmiranda danielfmiranda temporarily deployed to donate-wagta-1770-hide--tly1af December 15, 2023 00:11 Inactive
@danielfmiranda danielfmiranda temporarily deployed to donate-wagta-1770-hide--eqpwyz December 15, 2023 00:34 Inactive
@danielfmiranda danielfmiranda temporarily deployed to donate-wagta-1770-hide--bjnuwq December 15, 2023 00:42 Inactive
@danielfmiranda danielfmiranda changed the title commented out ways to give view disabled ways-to-give route Dec 15, 2023
Copy link
Contributor

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. Thanks @danielfmiranda!

Do you know if there will be a prod push for donate stack before the break? Asking because I see that this PR is set to be merged into main. If we don't plan on having another prod push, it might be safer that we create a feature branch and merge changes into there so that we can keep main clear in case anything comes up (e.g., needing to deploy a hotfix 🤞🏻 )

@danielfmiranda
Copy link
Collaborator Author

Hi @mmmavis thanks again for the review!

Regarding your question about the prod-push and the code freeze. Tyler and I have discussed in this slack thread that since this change is so minimal and on the now deprecated donate stack, we are OK to merge this in and to push to production.

@danielfmiranda danielfmiranda merged commit f3300b5 into main Dec 15, 2023
4 checks passed
@danielfmiranda danielfmiranda deleted the 1770-hide-ways-to-give-page branch December 15, 2023 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localized redirects not working for /help and /ways-to-give
2 participants