Use template literals for query selectors, use forEach instead of for

MozillaFoundation · Oct 21, 2021 · 9e00969 · 9e00969
1 parent b9615af
commit 9e00969
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/source/js/components/mozfest-hero-carousel/mozfest-hero-carousel.js b/source/js/components/mozfest-hero-carousel/mozfest-hero-carousel.js
@@ -77,11 +77,9 @@ class MozfestHeroCarousel {
 
 const MozfestHeroCarousels = {
   init: function () {
-    for (const carousel of document.querySelectorAll(
-      "[data-mozfest-hero-carousel]"
-    )) {
-      new MozfestHeroCarousel(carousel);
-    }
+    document
+      .querySelectorAll(`[data-mozfest-hero-carousel]`)
+      .forEach((e) => new MozfestHeroCarousel(e));
   },
 };
 

diff --git a/source/js/foundation/pages/mozfest/template-js-handler/home-banner.js b/source/js/foundation/pages/mozfest/template-js-handler/home-banner.js
@@ -1,12 +1,12 @@
-import {ReactGA} from "../../../../common";
+import { ReactGA } from "../../../../common";
 
 // For the featured banner type on mozefest homepage
 const watchFeaturedVideoHandler = () => {
   const watchVideoButton = document.querySelector(
       `#mozfest-home-watch-featured-video-button`
   );
-  const externalVideo = document.querySelector("#mozfest-hero-video iframe");
-  const internalVideo = document.querySelector("#mozfest-hero-video video");
+  const externalVideo = document.querySelector(`#mozfest-hero-video iframe`);
+  const internalVideo = document.querySelector(`#mozfest-hero-video video`);
 
   // If no video exists then do nothing
   if (!externalVideo && !internalVideo) {

diff --git a/source/js/main.js b/source/js/main.js
@@ -141,7 +141,7 @@ let main = {
     }
 
     // Mozfest pages
-    if (document.querySelector(".mozfest")) {
+    if (document.querySelector(`.mozfest`)) {
       MozfestHeroCarousels.init();
     }
   },