Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wagtail Component] Remove old Figure Grid component #1486

Closed
kristinashu opened this issue May 2, 2018 · 7 comments
Closed

[Wagtail Component] Remove old Figure Grid component #1486

kristinashu opened this issue May 2, 2018 · 7 comments
Assignees
Labels
engineering wagtail wagtail related issues

Comments

@kristinashu
Copy link

Figure Grid 2 was add in #1407

I have replaced the old Figure Grid with the new one (yay so much better!):
http://foundation.mozilla.org/opportunity/global-sprint/
https://foundation.mozilla.org/about/leadership/

I believe these are the only instances of it but @alanmoo will install a plugin to check #1445

Once confirmed, please remove the old Figure Grid component.

@kristinashu kristinashu added this to Backlog in Wagtail Cleanup via automation May 2, 2018
@kristinashu
Copy link
Author

@gvn as discussed as stand, you can probably remove the old Figure Grid as an option

@kristinashu kristinashu moved this from Backlog to Up Next in Wagtail Cleanup May 7, 2018
@gvn gvn self-assigned this Jun 5, 2018
@gvn gvn moved this from Up Next to In Progress in Wagtail Cleanup Jun 5, 2018
@gvn
Copy link
Contributor

gvn commented Jun 5, 2018

I did a local test to see what happens when components are removed from models.py and existing instances of them just disappear. So, we need to make super extra double sure that no instances remain before we fully deprecate.

I have seen some instances of what look like the Figure component on prod FWIW.

@alanmoo any traction on the plugin?

@gvn gvn removed their assignment Oct 12, 2018
@Pomax
Copy link
Contributor

Pomax commented Jan 28, 2019

Original FigureGrid was removed a while ago. The new block is still named "FigureGrid2" due to wagtail renaming being rather difficult, but in terms of issue triage, this work was completed.

@Pomax Pomax closed this as completed Jan 28, 2019
@kristinashu
Copy link
Author

I still see it under deprecated. It think it should be completely removed.

image

@kristinashu kristinashu reopened this Jan 28, 2019
@kristinashu kristinashu added this to Backlog in Foundation Site via automation Jan 28, 2019
@kristinashu kristinashu added the wagtail wagtail related issues label Jan 28, 2019
@Pomax
Copy link
Contributor

Pomax commented Jan 29, 2019

Ah, well-spotted. Interestingly, unless I'm even blinder, I don't see it listed as possible filter on our "block inventory" page. I don't know if that means there's something wrong with the block inventory, or whether it means there are zero pages that use it and so it's not even offering the option to filter based on it.

@alanmoo
Copy link
Contributor

alanmoo commented Jan 29, 2019

I believe it means it's not in use- I added it to a (private) page temporarily, and it was suddenly an option in the inventory list.

@Pomax
Copy link
Contributor

Pomax commented Jan 29, 2019

thanks, I think that means we should be able to impactlessly remove it.

@kristinashu kristinashu moved this from Backlog to Up Next in Foundation Site Feb 11, 2019
@youriwims youriwims self-assigned this Mar 11, 2019
@youriwims youriwims moved this from Up Next to In Progress in Foundation Site Mar 14, 2019
@youriwims youriwims moved this from In Progress to In Review in Foundation Site Mar 15, 2019
Foundation Site automation moved this from In Review to Done Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering wagtail wagtail related issues
Projects
No open projects
Wagtail Cleanup
  
In Progress
Development

No branches or pull requests

5 participants