Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the Participate page #3642

Closed
TheoChevalier opened this issue Sep 12, 2019 · 5 comments
Closed

Localize the Participate page #3642

TheoChevalier opened this issue Sep 12, 2019 · 5 comments

Comments

@TheoChevalier
Copy link
Contributor

Let’s make this page localizable!

There’s a start here: TheoChevalier@c24f166

But it’s missing Highlights, and CTA group 4 (and I don’t know how to tackle that)

@gideonthomas
Copy link
Contributor

@alanmoo to estimate this and put it in this milestone accordingly.

@alanmoo alanmoo added this to the Sep 23 milestone Sep 12, 2019
@TheoChevalier TheoChevalier self-assigned this Sep 18, 2019
@TheoChevalier
Copy link
Contributor Author

I think I figured out how to add CTA 4 fields, and since highlights will be handled in a follow up patch, taking this

@Pomax
Copy link
Contributor

Pomax commented Sep 19, 2019

Not to throw wrench in the wheel, but this page class is a modelling mess and we really should rip out all these -/2/3/4 duplications on duplications. Adding localisation now will make that job a lot harder, @alanmoo is there time for us to first refactor this page to something normal?

@alanmoo
Copy link
Contributor

alanmoo commented Sep 19, 2019

I think it's time to put the brakes on this for now; With the amount of effort, low traffic, and questions about the future nature of these pages I don't want to go down a rabbit hole that we don't need to. Théo, let's sync up on Monday about this.

@alanmoo alanmoo removed this from the Sep 23 milestone Sep 24, 2019
@Pomax Pomax added this to the Icebox milestone Sep 24, 2019
@Pomax Pomax added this to Backlog in Foundation Site via automation Sep 24, 2019
@cadecairos
Copy link

Closing this issue due to its age, if this is work that we still want to do, please refile this with up to date information so that it can be put in the correct milestone with up to date estimates.

Foundation Site automation moved this from Backlog to Done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants