Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the Initiatives page #3643

Closed
TheoChevalier opened this issue Sep 12, 2019 · 7 comments
Closed

Localize the Initiatives page #3643

TheoChevalier opened this issue Sep 12, 2019 · 7 comments

Comments

@TheoChevalier
Copy link
Contributor

Many fields are currently not localizable in Wagtail for this page, let’s fix that!

@gideonthomas
Copy link
Contributor

@alanmoo can you estimate this and accordingly put it into this milestone?

@alanmoo
Copy link
Contributor

alanmoo commented Sep 12, 2019

I'm estimating with the framing that I think this is mainly a matter of adding translation hooks to the various fields.

@alanmoo alanmoo added this to the Sep 23 milestone Sep 12, 2019
@TheoChevalier
Copy link
Contributor Author

I'm estimating with the framing that I think this is mainly a matter of adding translation hooks to the various fields.

Right, but it will also require to localize Highlights (and I don’t know if it’s as straightforward as adding translation hooks to fields)

@youriwims
Copy link
Contributor

youriwims commented Sep 17, 2019

@TheoChevalier after speaking with @Pomax , localizing the headers and initiative blocks is the most that can be done right now and we'll need to localize the highlights in a follow-up ticket. I believe @alanmoo and @kristinashu are currently in talks around how to approach highlights at the moment, so once that's done, we can create a follow-up ticket for localizing the highlights sections. 🙂 👍

@TheoChevalier
Copy link
Contributor Author

Sounds good @youriwims , thanks! I’ll go ahead and expose the strings in Pontoon, minus highlights. Having the initiative blocks alone should justify deploying translations of the page

@youriwims
Copy link
Contributor

Not a problem—sounds great! :)

@Pomax
Copy link
Contributor

Pomax commented Mar 31, 2020

Closing this issue due to having gone stale - if this is still something we want to do, let's file a new issue with all the information necessary for triaging.

@Pomax Pomax closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants