Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PNI: update badge #3767

Closed
2 tasks
kristinashu opened this issue Oct 11, 2019 · 5 comments · Fixed by #3802
Closed
2 tasks

PNI: update badge #3767

kristinashu opened this issue Oct 11, 2019 · 5 comments · Fixed by #3802
Assignees
@mmmavis
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering

Comments

@kristinashu
Copy link

kristinashu commented Oct 11, 2019 •
edited
Loading

@kristinashu kristinashu added the buyer's guide 🛍 Issues related to the buyer's guide label Oct 11, 2019
@kristinashu kristinashu added this to the Oct 21 milestone Oct 11, 2019
@kristinashu kristinashu mentioned this issue Oct 11, 2019
Closed
5 tasks
@natalieworth natalieworth self-assigned this Oct 15, 2019
@natalieworth
Copy link

@kristinashu I have the updated svg badges (with the stars here).

@mmmavis
Copy link
Collaborator

mmmavis commented Oct 18, 2019

@kristinashu is this about replacing existing badges with the files Nat attached?

@kristinashu
Copy link
Author

Yes that's right, they should be the same size and format (we're just replacing the checkmark with a star).

@mmmavis mmmavis self-assigned this Oct 18, 2019
@mmmavis
Copy link
Collaborator

mmmavis commented Oct 18, 2019 •
edited
Loading

@kristinashu @natalieworth product page's new badge (badge-star.svg) is in #909090 vs current one is in #000000. Just wanna confirm we are updating the colour to #909090 as well.

mmmavis added a commit that referenced this issue Oct 18, 2019
@mmmavis
fix #3767 - update badges
63928d3
@mmmavis mmmavis mentioned this issue Oct 18, 2019
Merged
@kristinashu
Copy link
Author

Honestly I'm not sure if that was intentional or not but I think #909090 actually looks good so let's go with that!

mmmavis added a commit that referenced this issue Oct 21, 2019
@mmmavis
Various PNI styling fixes (#3802)
0e00869 
* fix #3795 - update container background colour to make image background

* fix #3767 - update badges

* fix #3752 - update homepage banner

* fix broken image path

* fix #3791 - fix icon overlapping issue

* update SCSS variable names

* edited inline comment
@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various PNI styling fixes MozillaFoundation/foundation.mozilla.org
3 participants
@kristinashu @mmmavis @natalieworth