Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI] Product page - content update: "tips to protect yourself" #7380

Closed
2 tasks done
Pomax opened this issue Sep 13, 2021 · 3 comments
Closed
2 tasks done

[PNI] Product page - content update: "tips to protect yourself" #7380

Pomax opened this issue Sep 13, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@Pomax
Copy link
Contributor

Pomax commented Sep 13, 2021

Relevant part of the updated product page comp:

image

Comps on figma: https://www.figma.com/proto/GwdoUiY4fzVyeLfXsAJGPq/*Privacy-Not-Included-Website?page-id=548%3A72128&node-id=611%3A77813&viewport=283%2C48%2C0.08&scaling=min-zoom&starting-point-node-id=611%3A77813

@Pomax Pomax added this to the PNI Q3 2021 milestone Sep 13, 2021
@Pomax Pomax added engineering buyer's guide 🛍 Issues related to the buyer's guide frontend backend labels Sep 13, 2021
@danielfmiranda
Copy link
Collaborator

Hi @Pomax have a quick question about this ticket, I noticed that you mentioned the ability to add 0 ... N rich text blocks, and also said we should have the template check if there are > 0 blocks, and if so to render them.

Does that mean if the user does in fact have multiple blocks, we want to render multiple boxes of the same style that say "Tips to protect yourself?"

Asking because I am curious about the need for multiple blocks, I was under the impression this was a singular section on the product page, and was wondering why use multiple blocks, VS just adding one new "tips_to_protect_yourself" richtext field, and only rendering the section if it is not blank or ""

Thanks in advance!

@danielfmiranda
Copy link
Collaborator

Moving this ticket to blocked after a meeting with Pomax where we discovered that the RichTextBlock seems to be causing an issue with "Pickling" when visiting the PNI homepage:

image (1)

After researching some more, and Pomax posting about this in the wagtail slack, people have suggested that this could be a caching issue.

@benhohner we were wondering if this was something that Rich could maybe help us with, and if we could make this prioritised.

@danielfmiranda
Copy link
Collaborator

Closing as the PR has been merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants