Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI] Product page - update Blurb and Worst case blocks to rich text #7449

Closed
1 task done
kristinashu opened this issue Sep 22, 2021 · 7 comments
Closed
1 task done
Assignees
Labels
Milestone

Comments

@kristinashu
Copy link

kristinashu commented Sep 22, 2021

  • Update existing "Blurb" and "Worst case" blocks to rich text to enable the ability to have plain text, bold, italics, links
@Pomax
Copy link
Contributor

Pomax commented Sep 29, 2021

@richbrennan richbrennan changed the title [PNI] Product page - update Blur and Worst case blocks to rich text [PNI] Product page - update Blurb and Worst case blocks to rich text Sep 30, 2021
@richbrennan
Copy link
Contributor

richbrennan commented Oct 1, 2021

I wasn't able to recreate the "pickling" errors locally to investigate. I tried converting the Blurb field to rich text and adding some RT formatted content but no errors were thrown. Is it possible to provide the steps needed to reproduce please?

@Pomax
Copy link
Contributor

Pomax commented Oct 1, 2021

Absolutely. @danielfmiranda could I ask you to put the code swap you wrote into this issue? Hopefully this was just a matter of using the wrong class =)

@danielfmiranda
Copy link
Collaborator

danielfmiranda commented Oct 1, 2021

Hi @Pomax, of course! One thing I would like to note however is that I am experiencing the error in this PR which has to do with adding the "tips to protect yourself streamfield", vs updating blurb and worst case like requested in this ticket.

If you would like to take a look at the changes I made in order to use a rich text block streamfield, the file changes can be found here under the file products.py, and you can see what I am doing to render all of them on the front end in product_page.html

Please let me know if this helps, or if you need anything else. Thanks!

@richbrennan
Copy link
Contributor

Hi @danielfmiranda

Thanks for the links. Is this still an issue on the newer PR? #7576

If so I'm happy to check out the branch and take a look.

Cheers,

Rich.

@danielfmiranda
Copy link
Collaborator

Hi @richbrennan! Thanks for checking in, this is no longer an issue on the PR you linked, and it has been merged in to the codebase. I believe that we are now good to go in terms of working on this ticket

@danielfmiranda
Copy link
Collaborator

Closing as this is merged in. Thanks everyone for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants