-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PNI] Product page - update Blurb and Worst case blocks to rich text #7449
Comments
Trying a straight swap causes "pickling" errors, due to caching. Bits involved: actual cache dereference: |
I wasn't able to recreate the "pickling" errors locally to investigate. I tried converting the Blurb field to rich text and adding some RT formatted content but no errors were thrown. Is it possible to provide the steps needed to reproduce please? |
Absolutely. @danielfmiranda could I ask you to put the code swap you wrote into this issue? Hopefully this was just a matter of using the wrong class =) |
Hi @Pomax, of course! One thing I would like to note however is that I am experiencing the error in this PR which has to do with adding the "tips to protect yourself streamfield", vs updating blurb and worst case like requested in this ticket. If you would like to take a look at the changes I made in order to use a rich text block streamfield, the file changes can be found here under the file products.py, and you can see what I am doing to render all of them on the front end in product_page.html Please let me know if this helps, or if you need anything else. Thanks! |
Thanks for the links. Is this still an issue on the newer PR? #7576 If so I'm happy to check out the branch and take a look. Cheers, Rich. |
Hi @richbrennan! Thanks for checking in, this is no longer an issue on the PR you linked, and it has been merged in to the codebase. I believe that we are now good to go in terms of working on this ticket |
Closing as this is merged in. Thanks everyone for the review! |
The text was updated successfully, but these errors were encountered: