Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build "fellowship type" template #951

Closed
alanmoo opened this issue Jan 12, 2018 · 3 comments
Closed

Build "fellowship type" template #951

alanmoo opened this issue Jan 12, 2018 · 3 comments
Assignees
@mmmavis
Projects
Fellowships pages

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Jan 12, 2018

Based on https://projects.invisionapp.com/share/UQF78CYKM#/screens/271941399, build a static page with this structure. The content is less important than the structure, as we'll be using template tags to swap out the body text.
@alanmoo alanmoo created this issue from a note in Fellowships pages (To Do) Jan 12, 2018
@mmmavis
Copy link
Collaborator

mmmavis commented Jan 17, 2018

@taisdesouzalessa is https://projects.invisionapp.com/share/ZJ9YTAGEA#/screens/273603674 the WIP comps for this page type?

@taisdesouzalessa
Copy link
Contributor

taisdesouzalessa commented Jan 18, 2018 •
edited
Loading

@mmmavis nope, this is the comp:
https://invis.io/ZJ9YTAGEA#/273312988_FellowshipsUI_-_Specific_Fellowship_Page

Also, for Open Web page, the only one who has host orgs, this is the model (see addition of Host Orgs section into the template at the end of the page):
https://invis.io/ZJ9YTAGEA#/273843963_FellowshipsUI_-_Specific_Fellowship_Page_With_Host_Orgs

@mmmavis mmmavis self-assigned this Jan 18, 2018
mmmavis added a commit that referenced this issue Jan 24, 2018
@mmmavis
Related to #951 - fellowship type template & science fellowships
623b500
mmmavis added a commit that referenced this issue Jan 24, 2018
@mmmavis
# This is a combination of 17 commits.
2e24e4f 
# This is the 1st commit message:

fixed rebase conflicts

# This is the commit message #2:

fixed rebase conflicts

# This is the commit message #3:

fixed rebase conflicts

# This is the commit message #4:

updated elements on the page based on the latest comps

# This is the commit message #5:

added the last 2 sections in

# This is the commit message #6:

removed redundant code

# This is the commit message #7:

fixed rebase conflicts

# This is the commit message #8:

fixed rebase conflicts

# This is the commit message #9:

to match the updated comps

# This is the commit message #10:

fixed broken links

# This is the commit message #11:

named URL patterns

# This is the commit message #12:

custom template tag 'active_nav'

# This is the commit message #13:

applied custom template tag

# This is the commit message #14:

fixed linting error

# This is the commit message #15:

fixed linting error

# This is the commit message #16:

Related to #951 - fellowship type template & science fellowships

# This is the commit message #17:

featured fellow
mmmavis added a commit that referenced this issue Jan 24, 2018
@mmmavis
Related to #951 - fellowship type template & science fellowships
389c3a0
mmmavis added a commit that referenced this issue Jan 24, 2018
@mmmavis
Related to #951 - Fellowship type page + Science fellowship page
1b1dd55
@mmmavis mmmavis mentioned this issue Jan 24, 2018
Merged
@mmmavis mmmavis moved this from To Do to In progress in Fellowships pages Jan 24, 2018
mmmavis added a commit that referenced this issue Jan 26, 2018
@mmmavis
Related to #951 - Fellowship type page + Science fellowship page
d6b5c02
mmmavis added a commit that referenced this issue Jan 30, 2018
@mmmavis
Fellowship type pages (#994)
7c668bf 
* Related to #951 - Fellowship type page + Science fellowship page
@mmmavis
Copy link
Collaborator

mmmavis commented Jan 30, 2018

Merged into fellowships branch!

@mmmavis mmmavis closed this as completed Jan 30, 2018
Fellowships pages automation moved this from In progress to Done Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
None yet
Projects
No open projects
Fellowships pages
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alanmoo @mmmavis @taisdesouzalessa