Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News is showing up in reverse #972

Closed
cadecairos opened this issue Jan 18, 2018 · 1 comment
Closed

News is showing up in reverse #972

cadecairos opened this issue Jan 18, 2018 · 1 comment

Comments

@cadecairos
Copy link

When we updated the news page to support new years, we forgot to check the display order. It's currently displaying the oldest news first.

I think if we used shift() to build the array, we'd be all set.
@cadecairos
Copy link
Author

actually, unshift

cadecairos pushed a commit that referenced this issue Jan 18, 2018
Add years to the front of the newsByYear array as we iterate, rather …
5f2917c 
…than to the back [Fixes #972]
alanmoo added a commit that referenced this issue Jan 19, 2018
@alanmoo
Merge branch 'master' into fellowships
c0496d7 
* master:
  Django 1.11 (#976)
  Add years to the front of the newsByYear array as we iterate, rather than to the back [Fixes #972] (#975)
  Revert "Django 1.11 (#970)" (#973)
  Django 1.11 (#970)
  Create fake data for testing (#932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cadecairos