Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9266 Detail page - Link not required #10362

Merged
merged 1 commit into from Mar 29, 2023
Merged

Conversation

tbrlpld
Copy link
Collaborator

@tbrlpld tbrlpld commented Mar 21, 2023

Description

Follow-up PR to #10360

This PR removes the requirement for the detail pages to have a link defined.

The requirement has become cumbersome, because the detail pages are often used as the parent page of the article or publication page that the link should go to. With the link being required, we create a logical loop where the detail page can not be created because we can not link to the child and we can not create the child until the detail page exists.

Removing the requirement for a link breaks this logical loop. The editors can now create a detail page without a link, create the child page and then come back to the detail page to add the link. They do have to remember to come back to add the link though.

We could consider updating this to automatically link to the first child if no link is defined. But this needs to be checked with stakeholders and design if that is desirable.

While testing I also noticed that we should limit the types of child pages we can create on a detail page. #10361 will deal with that.

Link to sample test page: http://localhost:8000/cms/pages/add/wagtailpages/researchdetailpage/179/
Related PRs/issues: #9266

Checklist

Tests

  • Is the code I'm adding covered by tests? I could not find a good way to test this.

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

@tbrlpld tbrlpld changed the base branch from main to 9033-research-links-page-chooser March 21, 2023 21:34
@tbrlpld tbrlpld marked this pull request as ready for review March 21, 2023 21:34
Base automatically changed from 9033-research-links-page-chooser to main March 29, 2023 21:59
@tbrlpld tbrlpld force-pushed the 9266-detai-page-link-not-required branch from 36b8207 to 6fa2d9c Compare March 29, 2023 22:07
@tbrlpld tbrlpld merged commit 205c375 into main Mar 29, 2023
6 checks passed
@tbrlpld tbrlpld deleted the 9266-detai-page-link-not-required branch March 29, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants