#9266 Detail page - Link not required #10362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR to #10360
This PR removes the requirement for the detail pages to have a link defined.
The requirement has become cumbersome, because the detail pages are often used as the parent page of the article or publication page that the link should go to. With the link being required, we create a logical loop where the detail page can not be created because we can not link to the child and we can not create the child until the detail page exists.
Removing the requirement for a link breaks this logical loop. The editors can now create a detail page without a link, create the child page and then come back to the detail page to add the link. They do have to remember to come back to add the link though.
We could consider updating this to automatically link to the first child if no link is defined. But this needs to be checked with stakeholders and design if that is desirable.
While testing I also noticed that we should limit the types of child pages we can create on a detail page. #10361 will deal with that.
Link to sample test page: http://localhost:8000/cms/pages/add/wagtailpages/researchdetailpage/179/
Related PRs/issues: #9266
Checklist
Tests
Is the code I'm adding covered by tests?I could not find a good way to test this.Changes in Models:
Did I update or add new fake data?Did I squash my migration?Documentation:
Is my code documented?Did I update the READMEs or wagtail documentation?