Adjust uneven block spacing for mozfest #12373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
changed the title
robdivincenzo
force-pushed
the
TP1-632-12315-altered-mozfest-block-spacing
branch
from
fef6020
to
f9b2cb9
Compare
…cer blocks instead
robdivincenzo
changed the title
robdivincenzo
changed the title
robdivincenzo
changed the title
danielfmiranda
approved these changes
Jun 4, 2024
robdivincenzo
added
run visual regression tests
and removed
run visual regression tests
labels
|
➤ Simon Acosta Torres commented: PR has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts uneven spacing on the
Image Feature BlockandCarousel Text and Blockwhich are used on mozfest.It also reverts the auto-spacer portion of #11862. Since this affects the presentation of mozfest, we'll need to coordinate deployment with Marc. See discussion in #12315
Link to sample test page: https://mozfest-foundation-s-tp1-632-12-c2k71d.mofostaging.net/en/
Login Credentials:
username: admin2
password: admin2
Related PRs/issues: TP1-632 #12315
To Test
What's Coming Uph2 element and verify there is no spacer before (<div class="tw-mt-16 large:tw-mt-18"></div>) and after (<div class="tw-mt-8 large:tw-mt-10"></div>) it like there is on the mozfest production site. Note: there is a small visual regression where there is very little spacing above theh2but this is expected per discussion in Altered spacing between blocks on Mozfest Website #12315 and will be resolved with a manual spacer.Toshi Reagon & BigLovely Bandimage_teaser_block is narrower vs. productionSongs of the Livingwith the black background has also been tightened upMeet Tara Vassefielement has been tightened up compared to production┆Issue is synchronized with this Jira Story