Nuke Pug #1468
Merged
Nuke Pug #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmoo
suggested changes
Apr 27, 2018
There was a problem hiding this comment.
The nav seems to break when I run this locally. Can you confirm? I think @ScottDowne made changes to pug files for his recent navigation work.
README.md
Outdated
| @@ -157,9 +152,9 @@ Django powers the backend of the site, and we use Mezzanine with Django to provi | |||
| ## Development | |||
|
|
|||
| This project is based on Mezzanine, which is itself based on Django, so the documentation for both projects applies. | |||
There was a problem hiding this comment.
Update this line to Wagtail while you're at it.
|
How is the nav breaking? I'm seeing it working locally. |
|
Also seeing nav working on staged PR: https://foundation-mofostaging-pr-1468.herokuapp.com/wagtail/homepage/ |
alanmoo
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1442
I believe this should be safe now that everything is in Django templates(?). This will switch to a committed/future-editable version of the previously compiled master template.
pours one out for Pug... 馃嵑 馃惗