Separating JS dev and prod dependencies #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku was still installing all dependencies. I checked the doc: we need to use |
mmmavis
reviewed
May 27, 2019
| "eslint": "^5.16.0", | ||
| "eslint-config-prettier": "^4.3.0", | ||
| "eslint-plugin-prettier": "^3.1.0", | ||
| "eslint-plugin-react": "^7.13.0", | ||
| "event-stream": "3.3.4", | ||
| "html-entities": "^1.2.1", | ||
| "js-cookie": "2.2.0", | ||
| "mofo-bootstrap": "4.1.0", | ||
| "mofo-style": "^2.4.0", |
There was a problem hiding this comment.
Seems like we no longer uses mofo-style. I'll file a separate ticket to remove this.
mmmavis
approved these changes
May 27, 2019
There was a problem hiding this comment.
Looks good!
Maybe @cadecairos can chime in as I'm not super familiar with Heroku set up - do we need to have both NPM_CONFIG_PRODUCTION=true and NODE_ENV=production for every Heroku app (review apps + staging + prod)?
|
I'll let Mavis & Cade review this since I'm not super knowledgeable on all the packages we utilize. 馃槄 |
cadecairos
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're installing a bunch of JS deps that are not necessary for prod. I tried to separate dev/prod dependencies, but I might have missed one or two, can someone double check?
I'm pretty sure usingIt's already running with this setting, never mind :DNODE_ENV=productionfor review apps, staging and prod will be okay, but again, correct me if I'm wrong 馃槄It won't change anything for local dev or CI: all dependencies will still be installed when running
npm ior building the node image. Only review apps, staging and prod will run without dev dependencies.todos:
NPM_CONFIG_PRODUCTION=trueto staging,NPM_CONFIG_PRODUCTION=trueto prod.