Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lang reset #3768

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix lang reset #3768

merged 1 commit into from
Oct 11, 2019

Conversation

youriwims
Copy link
Contributor

@youriwims youriwims commented Oct 11, 2019 •
edited
Loading

Related PRs/issues #3766

Regression Issue from #3766: Snippet language field was being reset after country selection. This PR fixes that issue and allows language field to maintain originally selected value.

TheoChevalier
TheoChevalier approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@TheoChevalier TheoChevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+! I can confirm this is fixing the regression spotted

@youriwims youriwims merged commit 8bdfb3d into master Oct 11, 2019
@youriwims youriwims deleted the fix-lang-field branch October 11, 2019 22:45
@youriwims youriwims mentioned this pull request Oct 15, 2019
Merged
2 tasks
@youriwims youriwims added this to the Oct 21 milestone Oct 15, 2019
@youriwims youriwims self-assigned this Oct 15, 2019
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheoChevalier TheoChevalier TheoChevalier approved these changes

Assignees

@youriwims youriwims

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youriwims @TheoChevalier @patjouk