-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite the goggles login system to use id.wmo #529
Comments
Practically speaking, we cannot update goggles makes. In part because of how we intended the goggles to be used from the get go, but also due to technical choices made along the way: the notice is not a banner that we generate on top of goggle pages, it's literally hardcoded into every goggles make, so in order to update it, we would have to run through the database of goggle makes, parse each record, find the notice (in its various historical incarnations, which is tricky) and then update it to contain a new text. If we also want to include a link to the original site (which is an odd thing to ask for now that we're shutting it down, after four years of that never having been an issue) then things get quite a bit harder still, so as an assessment of the effort required to do this, my conclusion would have to be that, realistically, we cannot do this. |
Thanks for the info, @Pomax. One correction - we're not shutting Goggles down; we're moving it to mozilla.org where it will live under the Teach site. In theory (meaning: "with a bunch of work"), could we add this information to Goggles makes going forward, even if we're not able to apply this retroactively to existing makes? /cc @simonwex @ldecoursy |
The goggles codebase got too complicated to maintain, so any changes to how we want it to work (short of simply running it off a new domain) basically means we need to take out a few weeks to create a new library with the same capabilities as the goggles, but written as a maintainable library instead, and switch over to that instead. The goggles code as it exists now has effectively been in "we don't touch it" mode for a while now, pending the decision and free time to scrap the current implementation and redo it. |
cc @mmmavis see ^ |
Moving to next heartbeat |
Related tickets are filed here: https://github.com/mozilla/teach.webmaker.org/labels/The%20Goggles |
This ticket no longer reflects the work to be done. Goggles-related work for this heartbeat is mozilla/learning.mozilla.org#1220, so I'm updating this ticket's description |
@hannahkane status? [flagged!] |
will check in with @Pomax today. not sure of status. |
using id.wmo works, although the UX for it is rather poor at the moment and will need some polish. Login for goggles now works similarly to how we deal with discourse.wmo, where you get a new window/tab for logging into webmaker, which you can close once login finishes. |
thanks @Pomax. Pushing to next heartbeat for polish. |
@hannahkane status? [flagged!] |
This ticket is a dupe of #554 |
We need to:
/cc @Pomax - any flags on the above?
The text was updated successfully, but these errors were encountered: