Fixes #2750 Fixes #2733 Update the bookmark button state after a new …

…url is loaded (#2754) * Update the bookmark button state after a new url is loaded * Make url empty the default
MozillaReality · Feb 10, 2020 · 3949e4c · 3949e4c
1 parent fb42825
commit 3949e4c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java
@@ -18,10 +18,8 @@
 import org.mozilla.vrbrowser.R;
 import org.mozilla.vrbrowser.VRBrowserApplication;
 import org.mozilla.vrbrowser.browser.SettingsStore;
-import org.mozilla.vrbrowser.browser.engine.SessionStore;
 import org.mozilla.vrbrowser.ui.widgets.Windows;
 import org.mozilla.vrbrowser.utils.ServoUtils;
-import org.mozilla.vrbrowser.utils.StringUtils;
 import org.mozilla.vrbrowser.utils.UrlUtils;
 
 import java.io.UnsupportedEncodingException;
@@ -129,7 +127,7 @@ public WindowViewModel(Application application) {
         isMicrophoneEnabled = new MutableLiveData<>(new ObservableBoolean(true));
         isBookmarked = new MutableLiveData<>(new ObservableBoolean(false));
         isFocused = new MutableLiveData<>(new ObservableBoolean(false));
-        isUrlEmpty = new MutableLiveData<>(new ObservableBoolean(false));
+        isUrlEmpty = new MutableLiveData<>(new ObservableBoolean(true));
         isPopUpAvailable = new MutableLiveData<>(new ObservableBoolean(false));
         canGoForward = new MutableLiveData<>(new ObservableBoolean(false));
         canGoBack = new MutableLiveData<>(new ObservableBoolean(false));
@@ -323,9 +321,7 @@ public MutableLiveData<Spannable> getUrl() {
     }
 
     public void setUrl(@Nullable String url) {
-        if (url != null) {
-            this.url.setValue(new SpannableString(url));
-        }
+        setUrl(new SpannableString(url));
     }
 
     public void setUrl(@Nullable Spannable url) {
@@ -339,16 +335,6 @@ public void setUrl(@Nullable Spannable url) {
             return;
         }
 
-        if (StringUtils.isEmpty(aURL)) {
-            setIsBookmarked(false);
-
-        } else {
-            SessionStore.get().getBookmarkStore().isBookmarked(aURL).thenAcceptAsync(this::setIsBookmarked, mUIThreadExecutor).exceptionally(throwable -> {
-                throwable.printStackTrace();
-                return null;
-            });
-        }
-
         int index = -1;
         try {
             aURL = URLDecoder.decode(aURL, "UTF-8");

diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java
@@ -59,6 +59,7 @@
 import org.mozilla.vrbrowser.ui.widgets.dialogs.SelectionActionWidget;
 import org.mozilla.vrbrowser.ui.widgets.menus.ContextMenuWidget;
 import org.mozilla.vrbrowser.ui.widgets.menus.LibraryMenuWidget;
+import org.mozilla.vrbrowser.utils.StringUtils;
 import org.mozilla.vrbrowser.utils.ViewUtils;
 
 import java.util.Arrays;
@@ -1583,6 +1584,16 @@ public void captureImage() {
     @Override
     public void onLocationChange(@NonNull GeckoSession session, @Nullable String url) {
         mViewModel.setUrl(url);
+
+        if (StringUtils.isEmpty(url)) {
+            mViewModel.setIsBookmarked(false);
+
+        } else {
+            SessionStore.get().getBookmarkStore().isBookmarked(url).thenAcceptAsync(aBoolean -> mViewModel.setIsBookmarked(aBoolean), mUIThreadExecutor).exceptionally(throwable -> {
+                throwable.printStackTrace();
+                return null;
+            });
+        }
     }
 
     @Override