We need to override getItemId if we set hasStableIds to true (#3286)

MozillaReality · Apr 29, 2020 · e1c08cc · e1c08cc
1 parent 18270f0
commit e1c08cc
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/adapters/SitePermissionAdapter.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/adapters/SitePermissionAdapter.java
@@ -53,7 +53,7 @@ public SitePermissionAdapter(Context aContext, PermissionSiteItemCallback callba
     public void setSites(@NonNull List<SitePermission> sites) {
         if (mDisplayList == null) {
             mDisplayList = sites;
-            notifyItemRangeChanged(0, sites.size());
+            notifyDataSetChanged();
 
         } else {
             notifyDiff(sites);
@@ -78,7 +78,7 @@ public int getNewListSize() {
 
             @Override
             public boolean areItemsTheSame(int oldItemPosition, int newItemPosition) {
-                return mDisplayList.get(oldItemPosition).url.equals(newDisplayList.get(newItemPosition).url);
+                return mDisplayList.get(oldItemPosition).id == newDisplayList.get(newItemPosition).id;
             }
 
             @Override
@@ -125,6 +125,11 @@ public void onBindViewHolder(@NonNull RecyclerView.ViewHolder holder, int positi
         siteHolder.binding.setItem(site);
     }
 
+    @Override
+    public long getItemId(int position) {
+        return mDisplayList.get(position).id;
+    }
+
     @Override
     public int getItemCount() {
         return mDisplayList == null ? 0 : mDisplayList.size();