Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide YouTube's "Full screen is unavailable" disclaimer when Fullscreen 360 Media Controls opened #1056

Closed
cvan opened this issue Apr 2, 2019 · 2 comments
Closed

Hide YouTube's "Full screen is unavailable" disclaimer when Fullscreen 360 Media Controls opened #1056

cvan opened this issue Apr 2, 2019 · 2 comments
Assignees
@cvan
Labels
compatibility Web content compatibility issues enhancement This issue is a new feature or request
Milestone
v1.2

Comments

@cvan
Copy link
Contributor

cvan commented Apr 2, 2019 •
edited

Hardware

All

Steps to Reproduce

  1. Load a YouTube video, such as https://www.youtube.com/watch?v=JL6NAIVpl54&mozVideoProjection=360
  2. Notice this disclaimer in the bottom-right corner of the video: Full screen is unavailable. Learn More

image

Current Behavior

A disclaimer appears in the bottom-right corner of YouTube videos when fullscreened before entering a projection: Full screen is unavailable. Learn More

Expected Behavior

As Full screen is unavailable. Learn More disclaimer is confusing and unnecessary, it should not appear in the bottom-right corner of YouTube videos when fullscreened before entering a projection.

Possible Solution

We informed YouTube of this WebCompat issue a while back, but there's been no response. In the meantime, FxR can hide this disclaimer with its YouTube Web Extension content script, which was added in PR #1047 and improved upon in PR #1052.
@cvan cvan added enhancement This issue is a new feature or request compatibility Web content compatibility issues labels Apr 2, 2019
@philip-lamb philip-lamb mentioned this issue Apr 4, 2019
Closed
@philip-lamb philip-lamb added the P3 Backlog label Apr 4, 2019
@philip-lamb philip-lamb added this to the v1.2 milestone Apr 4, 2019
cvan added a commit that referenced this issue Apr 6, 2019
@cvan
automatically upgrade default YouTube video playback quality to HD 14…
d892f62 
…40p (fixes issue #1051); hide `Full screen is unavailable` message (fixes issue #1056)

- or via `vq=`/`query=` query-string parameter in URLs for youtube.com and youtube-nocookie.com
cvan added a commit that referenced this issue Apr 6, 2019
@cvan
automatically upgrade default YouTube video playback quality to HD 14…
a94be9b 
…40p (fixes issue #1051); hide `Full screen is unavailable` message (fixes issue #1056)

- or via `vq=`/`query=` query-string parameter in URLs for youtube.com and youtube-nocookie.com
cvan added a commit that referenced this issue Apr 6, 2019
@cvan
automatically upgrade default YouTube video playback quality to HD 14…
7debaaf 
…40p (fixes issue #1051); hide `Full screen is unavailable` message (fixes issue #1056)

- or via `vq=`/`query=` query-string parameter in URLs for youtube.com and youtube-nocookie.com
bluemarvin pushed a commit that referenced this issue Apr 11, 2019
@cvan @bluemarvin
automatically upgrade default YouTube video playback quality to HD 14…
e4efeda 
…40p (fixes issue #1051); hide `Full screen is unavailable` message (fixes issue #1056)

- or via `vq=`/`query=` query-string parameter in URLs for youtube.com and youtube-nocookie.com
MortimerGoro pushed a commit that referenced this issue Apr 11, 2019
@cvan @MortimerGoro
improve default playback quality of YouTube videos to 1440p (or vq=…
a125258 
…, `quality=` query-string parameter) (fixes issue #1051) (#1052)

* tidy up YouTube WebCompat WebExtension (follow up to PR #1047)

* automatically upgrade default YouTube video playback quality to HD 1440p (fixes issue #1051); hide `Full screen is unavailable` message (fixes issue #1056)

- or via `vq=`/`query=` query-string parameter in URLs for youtube.com and youtube-nocookie.com

* Fix SyntaxError

* Update to wait until player has resolutions available
@cvan cvan self-assigned this May 10, 2019
This was referenced May 14, 2019
Merged
Closed
@cvan
Copy link
Contributor Author

cvan commented May 14, 2019

I have fixed this locally and will make a PR shortly.

so, my bad: this was supposed to be fixed in PR #1052, but Firefox chokes on the syntax error in the style selector here https://github.com/MozillaReality/FirefoxReality/pull/1052/files#r283601515, which causes the Full screen is unavailable message to still be visible.

cvan added a commit that referenced this issue May 14, 2019
@cvan
YouTube improvements: enter 360 VR without having to first click YouT…
de41446 
…ube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056)
cvan added a commit that referenced this issue May 14, 2019
@cvan
YouTube improvements: enter 360 VR without having to first click YouT…
eee0654 
…ube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056)
@cvan cvan mentioned this issue May 14, 2019
Merged
philip-lamb pushed a commit that referenced this issue May 16, 2019
@cvan @philip-lamb
YouTube improvements: enter 360 VR without having to first click YouT…
0dfb62e 
…ube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056) (#1217)

* YouTube improvements: enter 360 VR without having to first click YouTube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056)

* toggle HD-quality helper + 360°-playback improvements when using YouTube's Single-Page-App navigation (vs. synchonrous page loads)
philip-lamb pushed a commit that referenced this issue May 16, 2019
@cvan @philip-lamb
YouTube improvements: enter 360 VR without having to first click YouT…
3303d6b 
…ube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056) (#1217)

* YouTube improvements: enter 360 VR without having to first click YouTube's Fullscreen button, set automatic 360 Projection on YouTube 360 videos (fixes issue #1215 and issue #1056)

* toggle HD-quality helper + 360°-playback improvements when using YouTube's Single-Page-App navigation (vs. synchonrous page loads)
@philip-lamb
Copy link
Contributor

Fixed in #1217.

@philip-lamb philip-lamb removed the P3 Backlog label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvan cvan

Labels
compatibility Web content compatibility issues enhancement This issue is a new feature or request
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
2 participants
@cvan @philip-lamb