Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send bookmarks to the correct window #1331

Closed
jvonitter opened this issue Jun 13, 2019 · 1 comment
Closed

Send bookmarks to the correct window #1331

jvonitter opened this issue Jun 13, 2019 · 1 comment
Assignees
Labels
Final Design Design complete. Any request for design revision must open in a new issue. UX Issue relates to UX
Projects
Milestone

Comments

@jvonitter
Copy link
Contributor

  • When multiple windows exist and the user clicks the bookmarks button, bookmarks should appear in the currently active window.
  • Bookmarks may appear in multiple windows if a user clicks the button while active in different windows.

needed by #1319
relates to #1326

@jvonitter jvonitter added Final Design Design complete. Any request for design revision must open in a new issue. UX Issue relates to UX labels Jun 13, 2019
@jvonitter jvonitter added this to the v1.3 milestone Jun 13, 2019
@jvonitter jvonitter modified the milestones: v1.3, v1.4 Jul 2, 2019
keianhzo added a commit that referenced this issue Jul 4, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
MortimerGoro pushed a commit that referenced this issue Jul 10, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
MortimerGoro pushed a commit that referenced this issue Jul 10, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
@jvonitter jvonitter added the PM/UX review PM/UX review needed prior to merge label Jul 11, 2019
MortimerGoro pushed a commit that referenced this issue Jul 12, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
keianhzo added a commit that referenced this issue Jul 16, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
@keianhzo keianhzo self-assigned this Jul 16, 2019
@keianhzo keianhzo added this to To do in Multiwindow Jul 18, 2019
@keianhzo keianhzo moved this from To do to Done in Multiwindow Jul 18, 2019
keianhzo added a commit that referenced this issue Jul 19, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
keianhzo added a commit that referenced this issue Jul 23, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
keianhzo added a commit that referenced this issue Jul 24, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
MortimerGoro pushed a commit that referenced this issue Jul 26, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
MortimerGoro pushed a commit that referenced this issue Aug 1, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
MortimerGoro pushed a commit that referenced this issue Aug 2, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
keianhzo added a commit that referenced this issue Aug 2, 2019
Also added support for bookmarks in all the windows as stated in the spec: #1331
bluemarvin pushed a commit that referenced this issue Aug 2, 2019
* Remove unused code

* Sessions Multiwindow implementation

Refactor of the current sessions code and added support for multi window.

* Implement window placement logic

* Refactored session settings to SessionManager

Always update all session when a session settings changes

* Keyboard multiwindow placement

* Added support for browser context menus

* Context Menu integration

* Fix parenting bug with three window moves

* Fix relayout on window resize. Set up better anchor points for left/right window resizes.

* Fixed Bookmarks navigation

Also added support for bookmarks in all the windows as stated in the spec: #1331

* Close sessions when a window is closed

Now when a window it's closed it's underlying sessions are closed.

* Add new tray icons

* Session restore


wip

* Fix resize gesture flickering and conflicts.

* Added support for restoring private sessions

* Save and restore window sizes

* Set up max reside sizes for multiwindow

* Exit fullscreen when window is closed

Also fixed a regression that made session not to close when a window is closed

* Fix fullscreen mode: hide other windows and make the fullscreened window the front one

* Fixed ADB issue and double loadUri when restoring windows.

* Make max windows dialog match  spec

* Curved mode fixes

* Fix rebase issues

* Fix cylindrical mode math for multiwindow.

* Fixed performance monitor from rebase and added missing tooltips

* Rebase fixes

* New Settings spec rebase fixes

* Added User-Agent multi-window support and fixed session restore issues

The home page was being loaded after a session restore. Now the home page is only loaded if the session is not restored. Also fixed some session restore issues to also restore session settings.

* Fix Tasckluster NoApi compilation issue

* Fixed context menu issues

* More ContextMenu fixes

* Fixed move window buttons get stuck in hover state

Fixes #1482

* Disable left/right move buttons when in private mode single window

* Multi-window Telemetry (#1443)

* Remove unneeded switchBookmarks call which causes a surface resize each time windows are updated

* Dime out world when closing a window

* Rebase fixes

* SessionStore rename

* Fix for session restore in WaveVR

* Fix movable keyboard for multiwindow

* Rebase fixes
@keianhzo
Copy link
Collaborator

keianhzo commented Aug 5, 2019

Closed by #1467

@keianhzo keianhzo closed this as completed Aug 5, 2019
@jvonitter jvonitter removed the PM/UX review PM/UX review needed prior to merge label Aug 6, 2019
Pike pushed a commit to mozilla-l10n/android-l10n that referenced this issue Aug 7, 2019
* Remove unused code

* Sessions Multiwindow implementation

Refactor of the current sessions code and added support for multi window.

* Implement window placement logic

* Refactored session settings to SessionManager

Always update all session when a session settings changes

* Keyboard multiwindow placement

* Added support for browser context menus

* Context Menu integration

* Fix parenting bug with three window moves

* Fix relayout on window resize. Set up better anchor points for left/right window resizes.

* Fixed Bookmarks navigation

Also added support for bookmarks in all the windows as stated in the spec: MozillaReality/FirefoxReality#1331

* Close sessions when a window is closed

Now when a window it's closed it's underlying sessions are closed.

* Add new tray icons

* Session restore


wip

* Fix resize gesture flickering and conflicts.

* Added support for restoring private sessions

* Save and restore window sizes

* Set up max reside sizes for multiwindow

* Exit fullscreen when window is closed

Also fixed a regression that made session not to close when a window is closed

* Fix fullscreen mode: hide other windows and make the fullscreened window the front one

* Fixed ADB issue and double loadUri when restoring windows.

* Make max windows dialog match  spec

* Curved mode fixes

* Fix rebase issues

* Fix cylindrical mode math for multiwindow.

* Fixed performance monitor from rebase and added missing tooltips

* Rebase fixes

* New Settings spec rebase fixes

* Added User-Agent multi-window support and fixed session restore issues

The home page was being loaded after a session restore. Now the home page is only loaded if the session is not restored. Also fixed some session restore issues to also restore session settings.

* Fix Tasckluster NoApi compilation issue

* Fixed context menu issues

* More ContextMenu fixes

* Fixed move window buttons get stuck in hover state

Fixes #1482

* Disable left/right move buttons when in private mode single window

* Multi-window Telemetry (#1443)

* Remove unneeded switchBookmarks call which causes a surface resize each time windows are updated

* Dime out world when closing a window

* Rebase fixes

* SessionStore rename

* Fix for session restore in WaveVR

* Fix movable keyboard for multiwindow

* Rebase fixes

X-Channel-Revision: [master] mozilla-mobile/android-components@8e9cb55
X-Channel-Revision: [master] mozilla-mobile/fenix@093b765
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@a1c7cce
X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@f76f19d
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Design Design complete. Any request for design revision must open in a new issue. UX Issue relates to UX
Projects
No open projects
Multiwindow
  
Done
Development

No branches or pull requests

3 participants