Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting freeze at the immersive mode in http://moonrider.xyz #2320

Closed
daoshengmu opened this issue Nov 19, 2019 · 12 comments · Fixed by #2341
Closed

Getting freeze at the immersive mode in http://moonrider.xyz #2320

daoshengmu opened this issue Nov 19, 2019 · 12 comments · Fixed by #2341
Assignees
Labels
bug This issue is a software or functional defect
Milestone

Comments

@daoshengmu
Copy link
Contributor

daoshengmu commented Nov 19, 2019

Configuration

Firefox Reality version: FxR 7
Firefox Reality build ID: 485355c

Hardware:
Oculus Quest

Steps to Reproduce

  1. Visit http://moonrider.xyz using the Oculus Browser on Quest
  2. Click to enter VR (glasses icon in bottom right corner) and press Begin UI.
  3. Go to Punch mode, and select a music to start.

Current Behavior

Once punching a block, the screen buffer will be freeze.

Expected Behavior

I checked it works properly in Oculus Browser, so we should be no problem with it.

Error Logs and Stack Traces

I would guess it would be related to gamepad haptic feedback or SurfaceTexture.

2019-11-19 12:38:06.770 5876-5970/org.mozilla.vrbrowser E/GeckoConsole: [JavaScript Error: "TypeError: this.gamepad.hapticActuators[n.actuatorIndex] is undefined" {file: "https://moonrider.xyz/build/build.js" line: 247}]
    pulse@https://moonrider.xyz/build/build.js:247:24084
    onHit@https://moonrider.xyz/build/build.js:16:15640
    checkCollision@https://moonrider.xyz/build/build.js:16:9979
    tick@https://moonrider.xyz/build/build.js:16:9616
    value@https://moonrider.xyz/vendor/aframe-master.min.js:265:11226
    value@https://moonrider.xyz/vendor/aframe-master.min.js:265:11760
    [172]</module.exports/</<@https://moonrider.xyz/vendor/aframe-master.min.js:396:132
    t@https://moonrider.xyz/vendor/aframe-master.min.js:90:3246
@daoshengmu daoshengmu added the bug This issue is a software or functional defect label Nov 19, 2019
@bluemarvin
Copy link
Contributor

We don't use EGLTextures, it's most likely the unhandled error.

@bluemarvin
Copy link
Contributor

We should still be able to exit immersive mode which seems to break when the page does.

@daoshengmu
Copy link
Contributor Author

Alright, the right fixes is here, #2198. Waiting for the haptic feedback support.

@daoshengmu daoshengmu self-assigned this Nov 19, 2019
@bluemarvin
Copy link
Contributor

The page crashing should not block us from exiting immersive mode. We should fix that first.

@daoshengmu
Copy link
Contributor Author

The page crashing should not block us from exiting immersive mode. We should fix that first.

It looks odd. const bool menuPressed = (controllerState.inputState.Buttons & ovrButton_Enter) != 0 is always false after the page crashing.

@bluemarvin
Copy link
Contributor

I think we are trying to exit but something is blocking it. When I pause with the oculus home button I see the spinner for the preview.

@daoshengmu
Copy link
Contributor Author

We are blocking by the VR immersive state [1]. It looks like OVR needs to call vrapi_SubmitFrame2 to end this frame's state, otherwise, we can't get new button states.

[1]

m.device->EndFrame(aDiscardFrame);

@bluemarvin
Copy link
Contributor

Is this Oculus only or does the same thing happen on HTC?

@daoshengmu
Copy link
Contributor Author

Is this Oculus only or does the same thing happen on HTC?

Unfortunately, they don't support Focus+ controllers, they didn't handle any actions from the controllers.

@daoshengmu
Copy link
Contributor Author

Focus+ doesn't have this problem. Checked via https://mortimergoro.github.io/webvr_long_pause/.

@MortimerGoro
Copy link
Contributor

Reopening until #2198 lands

@daoshengmu
Copy link
Contributor Author

Resolved by #2198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a software or functional defect
Projects
None yet
4 participants