Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L10n] The "Sync Now" button's name from the "Manage Account" prompt is cut off #2529

Closed
Softvision-RemusDranca opened this issue Dec 23, 2019 · 3 comments · Fixed by #2609
Closed
Labels
in progress L10n Localization [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 8-33550026 (933fcd5)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.
  • The app's language is set in "Francais".
  • You are logged into an FxA account and the account is synced.

[Steps to reproduce]:

  1. Click the Settings button.
  2. Click the "Manage Account" card.
  3. Observe the "Sync Now" button.

[Expected results]:

  • The button is correctly displayed.

[Actual results]:

  • The name of the button is cut off.

[Additional Notes]:

  • The locales on which this issue is reproducible are: DE, FR, IT and RU.
  • Attached is a screenshot of the issue:
    Manage Account Synced
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Dec 23, 2019
@jvonitter jvonitter added the L10n Localization label Jan 6, 2020
@jvonitter
Copy link
Contributor

@keianhzo looks like we'd be ok if the button grew a little here, but not if it's a crazy amount of special-casing.

@keianhzo
Copy link
Collaborator

keianhzo commented Jan 9, 2020

@jvonitter I've made the button wider although I can see this happening again with future languages as long as we have fixed sizes.

@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the latest Firefox Reality version 8 RC1 (7a444d0).
However, this issue is still reproducible with the French language for which I opened issue #2652 for tracking purpose having a lower severity.
Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2) and HTC Vive Focus (Android 7.1.2).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress L10n Localization [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants