Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L10n] The "Syncing" button's name from the "Manage Account" prompt is cut off #2532

Open
Softvision-RemusDranca opened this issue Dec 23, 2019 · 8 comments
Assignees
Labels
L10n Localization [QA]:Normal issue Label for QA to mark normal issues logged
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 8-33550026 (933fcd5)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.
  • The app's language is set in "Italian".
  • You are logged into an FxA account and the account is synced.

[Steps to reproduce]:

  1. Click the Settings button.
  2. Click the "Manage Account" card.
  3. Click the the "Sync Now" button.
  4. Observe the "Syncing" button.

[Expected results]:

  • The button is correctly displayed.

[Actual results]:

  • The name of the button is cut off.

[Additional Notes]:

  • The locales on which this issue is reproducible are: DE, NL, IT and PL.
  • Attached is a screenshot of the issue:
    Manage Acount Syncing
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Dec 23, 2019
@jvonitter jvonitter added the L10n Localization label Jan 6, 2020
@jvonitter
Copy link
Contributor

related to #2529

@jvonitter jvonitter added this to the #9 polish milestone Jan 8, 2020
@keianhzo
Copy link
Collaborator

This has already been addressed in #2609 for these specific languages. I see that this is still an issue for French but I don't feel that growing this button anymore with be a good solution as for most other languages the button will feel half empty. As we want to keep a constant width for all the buttons (@thenadj correct me if I'm wrong) I think the best approach is to adjust the translation and try to shorten it . That's probably something where @Pike could help with?

@thenadj
Copy link

thenadj commented Jan 21, 2020

I agree, let's try to adjust the translation and make it work.

@Pike Pike assigned Delphine and unassigned Pike Jan 22, 2020
@Pike
Copy link
Contributor

Pike commented Jan 22, 2020

Moving over to Delphine, who's the L10n PM for FxR.

@Delphine
Copy link
Collaborator

@TheoChevalier: Seems like this is still an issue for French, so wanted to loop you in, in case you had any suggestions to shorten the translation.
I admit that on my side, I can't really find an alternative for a shorter French translation ("Synchroniser maintenant"), so not sure this can be fixed on l10n side.

@bluemarvin bluemarvin modified the milestones: #9 polish, #10 features Feb 25, 2020
@keianhzo
Copy link
Collaborator

@Delphine Any updates on this?

@TheoChevalier
Copy link

Hi, I don’t see an easy way to shorten the French translation. Maybe just using "Synchroniser" (Sync)? Which, in French is obvious to be a verb, unlike English

I also don’t have a way of testing that UI and don’t see how it’s showing up in the screenshots above

@keianhzo
Copy link
Collaborator

@Delphine @TheoChevalier This is a problem is several languages, could we safely drop the "Now" from that string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L10n Localization [QA]:Normal issue Label for QA to mark normal issues logged
Projects
None yet
Development

No branches or pull requests

8 participants