New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English Keyboard input improvement suggestions for FxR #256

Closed
avrignaud opened this Issue Jul 25, 2018 · 18 comments

Comments

Projects
8 participants
@avrignaud

avrignaud commented Jul 25, 2018

Hardware: All
Steps to Reproduce: N/A
Actual Behavior: N/A
Expected Behavior:

  1. Expected to have "/" key available on main panel for easy URL entry
  2. Expected to have ".com" button available to speed entry
  3. Expected previously entered URL text to remain (so it is possible to add to it), and not have it erased
    Recommendation:
  4. / Key on main keyboard
  5. .com button on main keyboard
  6. URL text remains when selected unless backspace is selected (this presumes text is already selected)
@bluemarvin

This comment has been minimized.

Collaborator

bluemarvin commented Jul 25, 2018

The .com button is in the lower right corner.

@thenadj thenadj added the Design label Jul 25, 2018

@thenadj

This comment has been minimized.

thenadj commented Jul 25, 2018

Adding forward slash to keyboard improvements in Trello.
Keeping URL text is a good idea.
We are also adding a URL history UI to easily pick previously typed URL.

@nancyhang nancyhang added this to the V1.0 milestone Jul 26, 2018

@MortimerGoro

This comment has been minimized.

Collaborator

MortimerGoro commented Jul 26, 2018

Another user requested this: #84

@avrignaud

This comment has been minimized.

avrignaud commented Jul 26, 2018

All sounds good - and I also like the idea of a shift key on both sides of keyboard. Apologies for missing the .com button!

@cvan

This comment has been minimized.

Contributor

cvan commented Aug 1, 2018

btw, filed issue #288 for Caps Lock/Shift issues

@nancyhang nancyhang assigned nancyhang and thenadj and unassigned nancyhang Aug 2, 2018

@nancyhang nancyhang added this to To do in v1.0 via automation Aug 2, 2018

@nancyhang nancyhang added the P0 label Aug 2, 2018

@thenadj

This comment has been minimized.

thenadj commented Aug 3, 2018

Just FYI - This is currently #6 on our design priority list.

@MortimerGoro

This comment has been minimized.

Collaborator

MortimerGoro commented Aug 3, 2018

Have we considered using a split keyboard like Oculus/Chrome does (e.g numbers on a side of the keyboard, instead of a keyboard layout switch).

Maybe you mentioned it a design review meeting but don't remember now.

@larsbergstrom larsbergstrom modified the milestone: V1.0 Aug 3, 2018

@thenadj

This comment has been minimized.

thenadj commented Aug 7, 2018

@MortimerGoro Yes we have but we will not make changes for v1. It's on or list for v1.1 to explore split keyboard.

@thenadj

This comment has been minimized.

thenadj commented Aug 22, 2018

Updated keyboard design is complete.
UIS-6 Keyboard_011.pdf

@MortimerGoro

This comment has been minimized.

Collaborator

MortimerGoro commented Aug 23, 2018

URL text remains when selected unless backspace is selected (this presumes text is already selected

Could you give more details about this issue? I think that clearing the selected text after typing is a common behavior on browsers.

@avrignaud

This comment has been minimized.

avrignaud commented Aug 24, 2018

@MortimerGoro Issue is that automatically clearing the text makes it impossible to edit a URL. So if I make a typo and the URL fails, user can't just insert a character and try again - it literally clears all of that text and user is forced to enter the entire URL again which is painful in VR. So, the recommendation based on user feedback is to highlight the entire string - then user has two choices. One is to hit Delete which will clear all of it. Second is user can point and insert cursor into text at appropriate location.

@MortimerGoro

This comment has been minimized.

Collaborator

MortimerGoro commented Aug 24, 2018

@avrignaud I still don't get the issue. Users can already point and place the cursor into text to edit a URL. This is how it currently works. When the user clicks the URL the entire string is highlighted. Then they have two options:

  • With another click users can point and insert cursor into text at appropriate location.
  • Clicking backspace clears the text. Another letter clears the texts and inserts the letter

Oculus browser does the same. Also desktop.

@MortimerGoro

This comment has been minimized.

Collaborator

MortimerGoro commented Aug 24, 2018

the problem may be that sometimes when users click on the URL to place the cursor the text is still selected because the touch is nor processed. This may be caused because of #377

@keianhzo

This comment has been minimized.

Collaborator

keianhzo commented Aug 28, 2018

@thenadj Couple of questions:

  • The microphone button has disappeared from all the keyboards, is that right?
  • The symbols keyboard has the two shift buttons, do we want shifts in the symbols keyboard?
  • The "!" symbol is gone from the qwerty keyboard but is also not available in the symbols one, is that an error?
@thenadj

This comment has been minimized.

thenadj commented Aug 28, 2018

@keianhzo

  • Yes, no microphone button for V1. We will only do voice search for web search in v1 through the URL bar button
  • Yes, let's keep that in both places. We are adding the forward slash to the default view for convenience to enter URLs
  • ! being lost is an error, that needs to be in there. I will update the keyboard file today and find a place to add it back in.
@keianhzo

This comment has been minimized.

Collaborator

keianhzo commented Aug 28, 2018

@thenadj Also there is no button for switching to the secondary symbols keyboard, are the shifts suppose to do that or is the secondary symbols keyboard removed from this version? In case the shift buttons are not for switching to the secondary symbols keyboard, what are they for when in the symbols keyboard?

@thenadj

This comment has been minimized.

thenadj commented Aug 28, 2018

That's a mistake! I'll take a look and will fix it today.

@thenadj

This comment has been minimized.

thenadj commented Aug 29, 2018

UIS-6 Keyboard_012.pdf
UIS-6 is updated with secondary symbols keyboard and missing characters added in.

v1.0 automation moved this from To do to Done Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment