New Keyboard UI implementation #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
suggested changes
Aug 29, 2018
|
Minor nit, but on daydream, the expanded |
|
Fixed the long press issue, also added a dim to the keyboard when the popup is on. |
|
Fixed closing the pop up when clicking on the keyboard padding. |
bluemarvin
approved these changes
Aug 29, 2018
| StringBuilder popupCharacters = new StringBuilder(popupKey.popupCharacters); | ||
| switch (popupKey.codes[0]) { | ||
| case 110: { |
There was a problem hiding this comment.
part of the refactor should be replacing these numbers with const values so it is easier to read.
|
@MortimerGoro Feel free to review the code at your leisure and file any issues as follow ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256, Fixes #84, Fixes #333 Added new Keyboard UI
The keyboard code really needs a refactoring, I'll address that in the next keyboard iteration.