Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Multiprocess switch from Developer panel. #2912

Closed
bluemarvin opened this issue Mar 4, 2020 · 1 comment · Fixed by #2913
Closed

Remove Multiprocess switch from Developer panel. #2912

bluemarvin opened this issue Mar 4, 2020 · 1 comment · Fixed by #2913
Assignees
@bluemarvin
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#10 features

Comments

@bluemarvin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
GeckoView is dropping support for non-e10s mode. Since we are now switched to e10s, the option to turn e10s off needs to be removed from FxR.

Describe the solution you'd like
Remove the switch from the developer panel.
@bluemarvin bluemarvin added this to the #10 features milestone Mar 4, 2020
@bluemarvin bluemarvin self-assigned this Mar 4, 2020
bluemarvin added a commit that referenced this issue Mar 4, 2020
@bluemarvin
Permanently enable e10s
f4618a4 
Fixes #2912
@bluemarvin bluemarvin mentioned this issue Mar 4, 2020
Merged
keianhzo pushed a commit that referenced this issue Mar 9, 2020
@bluemarvin
Permanently enable e10s (#2913)
0f9e435 
Fixes #2912
@Softvision-RemusDranca
Copy link

I have verified this task on Firefox Reality version 10-40720037 (dbb8ed3) and the Multiprocess option is correctly removed from the Developer panel. Also, the UI of the other options is not affected.

Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2), HTC Vive Focus (Android 7.1.2) and Pico Neo 2 (Android 8.1.0).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluemarvin bluemarvin

Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Permanently enable e10s MozillaReality/FirefoxReality
2 participants
@bluemarvin @Softvision-RemusDranca