Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The three dot menu from History is wrongly displayed over the "Clear History" button when only two or one feeds are available #2960

Closed
Softvision-RemusDranca opened this issue Mar 13, 2020 · 6 comments · Fixed by #3450 or #3499
Assignees
Labels
[QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 10-40730015 (b958efb)

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • Oculus Quest - Android 7.1.1
  • Pico Neo2 - Android 8.1.0

[Prerequisites]:

  • The Firefox Reality browser is opened.
  • Have only 2 history feeds available in the History library.

[Steps to reproduce]:

  1. Click the History button from the tray.
  2. Hover over a history feed and click the three dot button.
  3. Observe the position of the menu.

[Expected results]:

  • The menu is displayed on the bottom side of the feed.

[Actual results]:

  • The menu is displayed at the top of the feed, covering the "Clear History" button.

[Notes]:

  • This issue is not reproducible if more than 2 feeds are available in History.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Minor issue Label for QA to mark minor issues logged label Mar 13, 2020
@bluemarvin bluemarvin added this to the #11 polish milestone Mar 20, 2020
daron-walters added a commit that referenced this issue Jun 2, 2020
…f a item is the last visible item in history feed. this prevents the context menu from showing above clear history button
@daron-walters
Copy link
Collaborator

The problem is that when there are 2 feed items the code was treating the first item as if it were the last item. Updated code to fix this here is the link to the fix on my local. Tested on oculus quest and pico neo2

keianhzo pushed a commit that referenced this issue Jun 3, 2020
…f a item is the last visible item in history feed. this prevents the context menu from showing above clear history button (#3450)
@Softvision-RemusDranca
Copy link
Author

Softvision-RemusDranca commented Jun 4, 2020

I have retested this issue using Firefox Reality 11-141551002 (8f4de9a) and it's partially fixed. The three dot menu from History is no longer displayed over the "Clear History" or over the button when triggered from the first feed displayed at the top.
However, the menu is displayed over the button if it's triggered from the second feed.
Also, this issue is now affecting the Downloads library as well (it was implemented after the issue was logged). Here, the menu is displayed over the "Sort By", and "Delete" buttons even when triggered from the 3rd position from the list.
Tested on Oculus Quest - Android 7.1.1, Pico Neo2 - Android 8.1.0 and HTC Vive Focus Plus - Android 7.1.2.

Considering this I will reopen this issue.

@daron-walters
Copy link
Collaborator

Hello I fix the issue in the downloads but I didnt understand the other issue "However, the menu is displayed over the button if it's triggered from the second feed." Can you provide a video of this issue so that I can troubleshoot

@Softvision-RemusDranca
Copy link
Author

@daron-walters Sorry for the late response, I was focusing on the 10.2 release.
From my testing, I observed that when clicking the 3 dot button for the first feed, the menu is displayed under the feed, and it's no longer displayed over the "Clear history" button, which is correct.
However, if I click the 3 dot button for the second feed (starting from the top), the menu is displayed at the top of the feed, and it's partially displayed over the "Clear history" button.
Here is a recording of this behavior: link.

@daron-walters
Copy link
Collaborator

daron-walters commented Jun 10, 2020

@Softvision-RemusDranca no worries. thanks for the video, I understand now. Here is the link show updated for both history and downloads Link Here

daron-walters added a commit that referenced this issue Jun 10, 2020
…g if a item is the last visible item in history feed. this prevents the context menu from showing above clear history button
daron-walters added a commit that referenced this issue Jun 10, 2020
…tem that would display menu below item instead of on top
daron-walters added a commit that referenced this issue Jun 12, 2020
…tem that would display menu below item instead of on top
daron-walters added a commit that referenced this issue Jun 12, 2020
…tem that would display menu below item instead of on top
keianhzo pushed a commit that referenced this issue Jun 15, 2020
…tem that would display menu below item instead of on top (#3499)
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible using Firefox Reality 11-141672019 (418d959). The three dot menu is no longer displayed over the "Clear History", "Delete" and "Sort By" buttons.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1), and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment