Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window resize drag handles are sometimes not responsive. #2990

Closed
bluemarvin opened this issue Mar 19, 2020 · 1 comment · Fixed by #3149
Closed

Window resize drag handles are sometimes not responsive. #2990

bluemarvin opened this issue Mar 19, 2020 · 1 comment · Fixed by #3149
Assignees
@bluemarvin
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#10 features

Comments

@bluemarvin
Copy link
Contributor

bluemarvin commented Mar 19, 2020 •
edited

Configuration

Firefox Reality version: 10
Firefox Reality build ID: 399e570

Hardware: Headsets with two controllers.

Steps to Reproduce

1, Place left controller on table so it isn't moving
2. Click window resize from hamburger menu
3. Try to use drag handle to resize window.

Current Behavior

Drag handles are non-responsive.

Expected Behavior

Window should be resizable.

Notes

Seems to be caused by 685f2cf
@bluemarvin bluemarvin added this to the #10 features milestone Mar 19, 2020
@bluemarvin bluemarvin self-assigned this Mar 19, 2020
@bluemarvin bluemarvin mentioned this issue Apr 10, 2020
Closed
bluemarvin added a commit that referenced this issue Apr 10, 2020
@bluemarvin
Ensure only focused controller is used for resize and moving
24b5ffe 
Fixes #2990
Fixes #3147

Note: This only fixes the crash from #3147. The issue of the resize
not being saved is still issue #2862.
@bluemarvin bluemarvin mentioned this issue Apr 10, 2020
Merged
bluemarvin added a commit that referenced this issue Apr 13, 2020
@bluemarvin
Ensure only focused controller is used for resize and moving (#3149)
207f86b 
Fixes #2990
Fixes #3147

Note: This only fixes the crash from #3147. The issue of the resize
not being saved is still issue #2862.
@Softvision-RemusDranca
Copy link

I have verified this issue and it's no longer reproducible with the latest Firefox Reality version 10-141042250 (207f86b) build. The window can be resized using the drag handles. Verified with 10 attempts.

Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2), HTC Vive Focus (Android 7.1.2) and Pico Neo 2 (Android 8.1.0).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluemarvin bluemarvin

Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Ensure only focused controller is used for resize and moving MozillaReality/FirefoxReality
2 participants
@bluemarvin @Softvision-RemusDranca