Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Tracking Protection functionality breaks if it's disabled on more than 3 websites in a row #3103

Closed
Softvision-RemusDranca opened this issue Apr 3, 2020 · 3 comments · Fixed by #3118
Assignees
Labels
[QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 10-140931839 (a360c20).

[Affected Platforms]:

  • HTC Vive Plus - Android 7.1.2
  • Pico Neo 2 - Android - 8.1.0
  • Oculus Quest - Android 7.1.1

[Prerequisites]:

  • The headset is turned on and the app is opened.
  • Tracking protection is enabled.

[Steps to reproduce]:

  1. Navigate to a website.
  2. Click the shield icon from the Awesomebar
  3. Click the "Disable" button from the pop-up.
  4. Redo the steps above for other 2 websites.
  5. Observe the behavior.

[Expected results]:

  • The Tracking Protection is successfully disabled for all websites above and added to the Exception list.

[Actual results]:

  • The Tracking Protection is not disabled for the last added website.
    OR
  • In some cases it's disabled but existing ones in the Exceptions list are replaced.

[Additional Notes]:

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Major issue Label for QA to mark major issues logged label Apr 3, 2020
@emstanley emstanley added this to the #10 features milestone Apr 6, 2020
@bluemarvin
Copy link
Contributor

This seems to work in Fenix Nightly.

@bluemarvin
Copy link
Contributor

This is caused by https://github.com/MozillaReality/FirefoxReality/blob/master/app/src/common/shared/org/mozilla/vrbrowser/browser/content/TrackingProtectionStore.java#L103
What happens is:

  1. The mContentBlockingController is cleared
  2. A list is made from position to position + count
  3. The mContentBlockingController block list is restored with the list

This drops all exceptions not in the position to position + count range.

@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the latest Firefox Reality version 10-140982354 (bce60f9) build. Now, the more then 3 websites can be disabled in a row and they are added to the Exceptions list.

Tested on Oculus Go (Android 7.1.2), Oculus Quest (Android 7.1.1), HTC Vive Focus Plus (Android 7.1.2), HTC Vive Focus (Android 7.1.2) and Pico Neo 2 (Android 8.1.0).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
4 participants