Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The previous session is not restored after changing the device language #3530

Closed
Softvision-RemusDranca opened this issue Jun 22, 2020 · 3 comments · Fixed by #3545
Closed

The previous session is not restored after changing the device language #3530

Softvision-RemusDranca opened this issue Jun 22, 2020 · 3 comments · Fixed by #3545
Assignees
@bluemarvin
Labels
[QA]:Caught_by_exploratory Bugs found during exploratory testing [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#11 polish

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 11-141740850 (77deb30).

[Affected Platforms]:

  • HTC Vive Focus - Android 7.1.2
  • Pico Neo2 - Android 8.1.0

[Prerequisites]:

  • The Firefox Reality browser is open.

[Steps to reproduce]:

  1. Navigate to a website.
  2. Exit the app and change the device language.
  3. Reopen the app and observe the behavior.

[Expected results]:

  • The previous navigated website is displayed.

[Actual results]:

  • The Homepage is displayed.

[Notes]:

  • The Homepage is displayed after each quit and resume, until the device is restarted.
  • I was not able to reproduce the issue on the Oculus devices, I presume that this is because the device needs to be restarter for the language settings to be applied.
  • Attached is the screen recording of this issue:
    • Screen Recording: link.
@Softvision-RemusDranca Softvision-RemusDranca added [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Caught_by_exploratory Bugs found during exploratory testing labels Jun 22, 2020
@bluemarvin
Copy link
Contributor

I tested this on the Neo2 and was not able to reproduce the issue.

@bluemarvin bluemarvin self-assigned this Jun 24, 2020
@bluemarvin bluemarvin added this to the #11 polish milestone Jun 24, 2020
@bluemarvin bluemarvin mentioned this issue Jun 24, 2020
Closed
bluemarvin added a commit that referenced this issue Jun 24, 2020
@bluemarvin
Only load home page if session uri is blank on new intent.
0aad463 
Fixes #3530
Fixes #3543
@bluemarvin bluemarvin mentioned this issue Jun 24, 2020
Merged
@bluemarvin
Copy link
Contributor

I can now reproduce the issue. The window can not be restored for this issue to be reproduced. Clearing browser data before launch makes it 100% reproducible:

keianhzo pushed a commit that referenced this issue Jun 26, 2020
@bluemarvin
Only load home page if session uri is blank on new intent. (#3545)
50e2735 
Fixes #3530
Fixes #3543
@Softvision-GeluHaiduc
Copy link

I have verified this issue with Firefox Reality version 11 RC2 (5fd1bfd) installed on the HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
Now, the previous session is restored after changing the device language.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluemarvin bluemarvin

Labels
[QA]:Caught_by_exploratory Bugs found during exploratory testing [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#11 polish
Development

Successfully merging a pull request may close this issue.

Only load home page if session uri is blank on new intent. MozillaReality/FirefoxReality
3 participants
@bluemarvin @Softvision-RemusDranca @Softvision-GeluHaiduc